Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: KSP-RO/RP-1
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e62709cb896b
Choose a base ref
...
head repository: KSP-RO/RP-1
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 36476aeeefb3
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Sep 20, 2018

  1. Fix NewCrewStations.cfg (#783)

    As I read this, the point of this contract is to send crew to an empty station.  But the current requirement is set to only allow the contract to occur when there are less than 3 vacant seats available.  Meaning if a station can support 5 crew and you have 3 on the station, the contract would become available because "EmptyCrewSpace()" would return a result of 2.  By using "v.CrewCount()==0" we should only allow the contract to occur when a station has no crew on board, regardless of how many available seats there may be.
    ctiberious authored and Tidal-Stream committed Sep 20, 2018
    Copy the full SHA
    3607ac8 View commit details

Commits on Oct 15, 2018

  1. Merge pull request #901 from Tidal-Stream/newcrewstations

    Fix NewCrewStations.cfg (port be7a24b) (#783)
    ec429 authored Oct 15, 2018
    Copy the full SHA
    36476ae View commit details
Showing with 2 additions and 2 deletions.
  1. +2 −2 GameData/RP-0/Contracts/Space Stations/New Crew Station.cfg
4 changes: 2 additions & 2 deletions GameData/RP-0/Contracts/Space Stations/New Crew Station.cfg
Original file line number Diff line number Diff line change
@@ -53,8 +53,8 @@ CONTRACT_TYPE
requiredValue = true
hidden = true
uniquenessCheck = GROUP_ACTIVE
targetVessel1 = AllVessels().Where(v => v.VesselType() == Station && v.EmptyCrewSpace()<3 && v.FreeDockingPorts()>0).SelectUnique()
title = Must have a station with less than 3 empty seats
targetVessel1 = AllVessels().Where(v => v.VesselType() == Station && v.CrewCount()==0 && v.FreeDockingPorts()>0).SelectUnique()
title = Must have a station with no crew on board
}
DATA
{