Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.shell-conduit: fix build #48437

Merged
merged 1 commit into from Oct 15, 2018
Merged

haskellPackages.shell-conduit: fix build #48437

merged 1 commit into from Oct 15, 2018

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 14, 2018

Motivation for this change

backport #48015

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change
  • Tested compilation of all pkgs that depend on this change
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

Can you do a cherry-pick as described in the manual? (cherry-pick from 096be6d)

@rnhmjoj
haskellPackages.shell-conduit: fix build
2334e37 
(cherry picked from commit 096be6d)
Reason: the package is broken in NixOS stable.
@Mic92 Mic92 merged commit ae16537 into NixOS:release-18.09 Oct 15, 2018
@rnhmjoj rnhmjoj deleted the shell-conduit-backport branch February 23, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti peti is a code owner

@ryantm ryantm Awaiting requested review from ryantm ryantm is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rnhmjoj @infinisil @Mic92 @GrahamcOfBorg