Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dolphin-emu: fix metadata (GPLv2 -> GPLv2+, http -> https) #48445

Merged
merged 1 commit into from Oct 15, 2018
Merged

dolphin-emu: fix metadata (GPLv2 -> GPLv2+, http -> https) #48445

merged 1 commit into from Oct 15, 2018

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Oct 15, 2018

Motivation for this change

Dolphin has been GPLv2+ since 2015. See https://dolphin-emu.org/blog/2015/05/25/relicensing-dolphin/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor

bhipple commented Oct 15, 2018

@GrahamcOfBorg build dolphin-emu

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: dolphin-emu

Partial log (click to expand)

Cannot nix-instantiate `dolphin-emu' because:
error: attribute 'dolphin-emu' in selection path 'dolphin-emu' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: dolphin-emu

Partial log (click to expand)

Cannot nix-instantiate `dolphin-emu' because:
error: attribute 'dolphin-emu' in selection path 'dolphin-emu' not found

@samueldr
Copy link
Member

samueldr commented Oct 15, 2018 •
edited

(The attribute doesn't match the folder or package name for Dolphin.)

@GrahamcOfBorg build dolphinEmu dolphinEmuMaster

Though this won't cause any change in the build, since this is a meta change; the bot already tagged it as "0" changes.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: dolphinEmu, dolphinEmuMaster

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dolphinEmu, dolphinEmuMaster

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dolphinEmu, dolphinEmuMaster

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: dolphinEmu, dolphinEmuMaster

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dolphinEmu, dolphinEmuMaster

Partial log (click to expand)

copying path '/nix/store/mklyd0vmkvp30vblyllhspl62bz9znwv-hidapi-0.8.0-rc1' from 'https://cache.nixos.org'...
copying path '/nix/store/pbz2l7iwnc2nh0fja4d1mdlb2gfwm80a-mbedtls-2.12.0' from 'https://cache.nixos.org'...
copying path '/nix/store/9s2bb3zlzzvqrv2s1j2yj4w7kbh7gnzb-portaudio-190600-20161030' from 'https://cache.nixos.org'...
copying path '/nix/store/7sg1yj5khjcxpv2vd7rlznis63r4fv6j-sfml-2.5.0' from 'https://cache.nixos.org'...
copying path '/nix/store/k9azkz9l1mnxbgnfzqh770l9cmbip92r-soundtouch-2.0.0' from 'https://cache.nixos.org'...
copying path '/nix/store/pqlr5xlm1dnn2vhngnpy2wg3ilhg3xyd-vulkan-loader-1.1.85' from 'https://cache.nixos.org'...
copying path '/nix/store/6qrrlxzfvx2qwhglglaj2c3j3b4b97ww-dolphin-emu-5.0' from 'https://cache.nixos.org'...
copying path '/nix/store/zlcghvw6asx28k9z82sckr2v1v0h9w4c-dolphin-emu-2018-09-24' from 'https://cache.nixos.org'...
/nix/store/6qrrlxzfvx2qwhglglaj2c3j3b4b97ww-dolphin-emu-5.0
/nix/store/zlcghvw6asx28k9z82sckr2v1v0h9w4c-dolphin-emu-2018-09-24

@samueldr samueldr merged commit ac7bf94 into NixOS:master Oct 15, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dolphinEmu, dolphinEmuMaster

Partial log (click to expand)

copying path '/nix/store/7sg1yj5khjcxpv2vd7rlznis63r4fv6j-sfml-2.5.0' from 'https://cache.nixos.org'...
copying path '/nix/store/pg4p0lq8zf2zrdfgr1dqq73199d4d8wr-xcb-util-wm-0.4.1' from 'https://cache.nixos.org'...
copying path '/nix/store/lrh9687rwr0l9yhl841lkn96yj2v4mvm-xvidcore-1.3.5' from 'https://cache.nixos.org'...
copying path '/nix/store/983zbwvzh1haajw55yqqsznz0bck6qql-qtbase-5.11.1' from 'https://cache.nixos.org'...
copying path '/nix/store/vizbvm1s4hlmf1xlr8kf2wn6i1bl46zw-ffmpeg-3.4.4' from 'https://cache.nixos.org'...
copying path '/nix/store/6qrrlxzfvx2qwhglglaj2c3j3b4b97ww-dolphin-emu-5.0' from 'https://cache.nixos.org'...
copying path '/nix/store/n5ykmay4bzqdplpy9i1i2wlgzkllmv28-qtbase-5.11.1-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/zlcghvw6asx28k9z82sckr2v1v0h9w4c-dolphin-emu-2018-09-24' from 'https://cache.nixos.org'...
/nix/store/6qrrlxzfvx2qwhglglaj2c3j3b4b97ww-dolphin-emu-5.0
/nix/store/zlcghvw6asx28k9z82sckr2v1v0h9w4c-dolphin-emu-2018-09-24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@delroth @bhipple @GrahamcOfBorg @samueldr