Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hmetis package #42843

Merged
merged 1 commit into from Jul 2, 2018
Merged

add hmetis package #42843

merged 1 commit into from Jul 2, 2018

Conversation

fragamus
Copy link
Contributor

@fragamus fragamus commented Jul 1, 2018

Motivation for this change

add hmetis package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [ x] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@fragamus
Copy link
Contributor Author

fragamus commented Jul 1, 2018

merged into one commit

@infinisil infinisil mentioned this pull request Jul 1, 2018
Closed
8 tasks
infinisil
infinisil approved these changes Jul 1, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has been reviewed by me in #42745 already, looking good now

@srhb srhb merged commit f06ce58 into NixOS:master Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fragamus @infinisil @srhb @GrahamcOfBorg