Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HEIF support #42841

Merged
merged 7 commits into from Jul 3, 2018
Merged

HEIF support #42841

merged 7 commits into from Jul 3, 2018

Conversation

gebner
Copy link
Member

@gebner gebner commented Jul 1, 2018

Motivation for this change

HEIF is a new image format. This PR adds the libheif library, and enables HEIF support in imagemagick, gimp, and krita.

Mainly waiting for ofborg to determine whether this should go to staging. Closure size increase is between 3-6 megabytes (1-3%).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gimp, imagemagick, imagemagick7, krita, libde265, libheif

Partial log (click to expand)

/nix/store/gxs008b6nr0qsr3fbjijrm0a7b64ry3k-gimp-2.10.2
/nix/store/gdi4xvsnyyjcps66gq4qvs4xjhi70p03-imagemagick-6.9.9-34
/nix/store/gq9sf710lf6qdwz1a8x5xrx5vfqcck85-imagemagick-7.0.8-2
/nix/store/l9pvd94in3yx0nwnpbjyfbqi6mgw3jvd-krita-4.1.0
/nix/store/nspsdc2mbgaf26gmc2kl8vbha1sd4skn-libde265-1.0.3
/nix/store/7swv2rv3l8riq0q25fi2ij3kw2dqza3w-libheif-1.3.2

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gimp, imagemagick, imagemagick7, krita, libde265, libheif

Partial log (click to expand)

make[4]: Leaving directory '/build/gimp-2.10.2/app/tests'
make[3]: *** [Makefile:1361: check-recursive] Error 1
make[3]: Leaving directory '/build/gimp-2.10.2/app/tests'
make[2]: *** [Makefile:1233: check-recursive] Error 1
make[2]: Leaving directory '/build/gimp-2.10.2/app'
make[1]: *** [Makefile:850: check-recursive] Error 1
make[1]: Leaving directory '/build/gimp-2.10.2'
make: *** [Makefile:1143: check] Error 2
builder for '/nix/store/xhv9l6jl1jyhy0zn0z6hq63vs8fpjgiq-gimp-2.10.2.drv' failed with exit code 2
error: build of '/nix/store/xhv9l6jl1jyhy0zn0z6hq63vs8fpjgiq-gimp-2.10.2.drv', '/nix/store/zz6kkydii54y3fd8zvkrs1940szhaqd6-krita-4.1.0.drv' failed

@gebner gebner merged commit 7138bc0 into NixOS:master Jul 3, 2018
eadwu pushed a commit to eadwu/nixpkgs that referenced this pull request Jul 3, 2018
@gebner
imagemagick_light: remove heif dependency
6fcf294 
See NixOS#42841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gebner @GrahamcOfBorg