Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-90: Fix tag lookups for artist #689

Merged
merged 2 commits into from
Jul 3, 2018
Merged

Conversation

sambhav
Copy link
Collaborator

@sambhav sambhav commented Jul 1, 2018

Tag lookups for artist was using a search modifier to search for sortnames and aliases with a particular boost. This is not needed or supported anymore (since it uses a weird syntax) with Solr since these fields are searched by default with a particular set of boosts

Verified

This commit was signed with the committer’s verified signature. The key has expired.
sambhav Sambhav Kothari
Tag lookups for artist was using a search modifier to search for sortnames and aliases with a particular boost. This is not needed anymore with Solr since these fields are searched by default with a particular set of boosts
@sambhav sambhav changed the title Fix tag lookups for artist SOLR-90: Fix tag lookups for artist Jul 1, 2018
@sambhav sambhav requested review from mwiencek and yvanzo July 1, 2018 13:37
Copy link
Member

@mwiencek mwiencek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the alias_query subroutine is now unused and can be removed.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
sambhav Sambhav Kothari
@sambhav
Copy link
Collaborator Author

sambhav commented Jul 2, 2018

@mwiencek updated.

@sambhav
Copy link
Collaborator Author

sambhav commented Jul 2, 2018

@brainzbot retest this please.

@goodenep
Copy link

goodenep commented Jul 2, 2018

Just tested and Artist only tag lookup still does not work.

Copy link
Contributor

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@goodenep : It was not deployed, it works in beta already.

@yvanzo
Copy link
Contributor

yvanzo commented Jul 3, 2018

@goodenep : It is now fixed for every MusicBrainz server, check artist only tag lookup.

@goodenep
Copy link

goodenep commented Jul 3, 2018

Thank you and everyone else for this "fast" fix. I apologize for being so pushy. I can verify it works.

@mwiencek mwiencek merged commit ee1beca into metabrainz:master Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants