SOLR-90: Fix tag lookups for artist #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tag lookups for artist was using a search modifier to search for sortnames and aliases with a particular boost. This is not needed anymore with Solr since these fields are searched by default with a particular set of boosts
samj1912
changed the title
mwiencek
requested changes
Jul 2, 2018
|
@mwiencek updated. |
|
@brainzbot retest this please. |
|
Just tested and Artist only tag lookup still does not work. |
|
@goodenep : It is now fixed for every MusicBrainz server, check artist only tag lookup. |
|
Thank you and everyone else for this "fast" fix. I apologize for being so pushy. I can verify it works. |
mwiencek
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag lookups for artist was using a search modifier to search for sortnames and aliases with a particular boost. This is not needed or supported anymore (since it uses a weird syntax) with Solr since these fields are searched by default with a particular set of boosts