pythonPackages.backports_shutil_get_terminal_size: 1.0 -> 2018-06-30 #42840

timokau · 2018-07-01T15:39:57Z

Motivation for this change

@FRidh do you think it is acceptable to build from master, given that the released version seems pretty broken and there hasn't been any change in years?

There is a discussion here but it is rather lengthy.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

dotlambda · 2018-07-01T22:37:23Z

pkgs/development/python-modules/backports_shutil_get_terminal_size/default.nix

+  src = fetchFromGitHub {
+    owner = "chrippa";
+    repo = "backports.shutil_get_terminal_size";
+    rev = "159e269450dbf37c3a837f6ea7e628d59acbb96a";


This commit is from 2016-02-21, so please use this as the version.

I thought it was supposed to be the date of inclusion of nixpkgs. Doesn't matter either way, I'll change it.

I'm not sure actually, but the date of the commit makes much more sense to me.

Please don't forget to also update the commit message.

dotlambda · 2018-07-01T22:38:17Z

pkgs/development/python-modules/backports_shutil_get_terminal_size/default.nix

@@ -23,4 +31,4 @@ if !(pythonOlder "3.3") then null else buildPythonPackage rec {
    homepage = https://github.com/chrippa/backports.shutil_get_terminal_size;
    license = with lib.licenses; [ mit ];
  };


Do you want to maintain this? Packages not fetched from PyPI need someone updating them by hand.

I doubt there will be another update before the EOL of python 2.7. But sure, I'll maintain just in case.

dotlambda · 2018-07-01T22:38:40Z

pkgs/development/python-modules/backports_shutil_get_terminal_size/default.nix

 , pytest
 , pythonOlder
 }:

 if !(pythonOlder "3.3") then null else buildPythonPackage rec {
  pname = "backports.shutil_get_terminal_size";
-  version = "1.0.0";
+  version = "2018-06-30";


unstable-{date}

dotlambda · 2018-07-01T23:15:16Z

pkgs/applications/science/math/sage/sage-src.nix

-      name = "zero_division_error_formatting.patch";
-      url = "https://git.sagemath.org/sage.git/patch/?h=f79070ddd09fa0ad6b340b097bd8d690a7aa35f0";
-      sha256 = "02wsc3wbp8g8dk5jcjyv18d9v537h3zp5v8lwir46j4na4kj0dlb";
-    })


This probably has nothing to do with the Python package, has it?

It removes the sage patch that was applied to deal with an unpatched version of the backport.

dotlambda · 2018-07-01T23:15:24Z

pkgs/development/python-modules/backports_shutil_get_terminal_size/default.nix

  };

  checkInputs = [
    pytest
  ];

-  meta = {
+  meta = with stdenv.lib; {


with lib;

dotlambda · 2018-07-02T15:51:36Z

@GrahamcOfBorg build python2.backports_shutil_get_terminal_size python3.backports_shutil_get_terminal_size

GrahamcOfBorg · 2018-07-02T15:52:10Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: python2.backports_shutil_get_terminal_size, python3.backports_shutil_get_terminal_size

Partial log (click to expand)

Cannot nix-instantiate `python2.backports_shutil_get_terminal_size' because:
error: attribute 'backports_shutil_get_terminal_size' in selection path 'python2.backports_shutil_get_terminal_size' not found

Cannot nix-instantiate `python3.backports_shutil_get_terminal_size' because:
error: attribute 'backports_shutil_get_terminal_size' in selection path 'python3.backports_shutil_get_terminal_size' not found

GrahamcOfBorg · 2018-07-02T15:52:16Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: python2.backports_shutil_get_terminal_size, python3.backports_shutil_get_terminal_size

Partial log (click to expand)

Cannot nix-instantiate `python2.backports_shutil_get_terminal_size' because:
error: attribute 'backports_shutil_get_terminal_size' in selection path 'python2.backports_shutil_get_terminal_size' not found

Cannot nix-instantiate `python3.backports_shutil_get_terminal_size' because:
error: attribute 'backports_shutil_get_terminal_size' in selection path 'python3.backports_shutil_get_terminal_size' not found

dotlambda · 2018-07-02T15:54:35Z

@GrahamcOfBorg build python2.pkgs.backports_shutil_get_terminal_size python3.pkgs.backports_shutil_get_terminal_size

GrahamcOfBorg · 2018-07-02T15:55:19Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.backports_shutil_get_terminal_size

The following builds were skipped because they don't evaluate on x86_64-linux: python3.pkgs.backports_shutil_get_terminal_size

Partial log (click to expand)

reading manifest file 'backports.shutil_get_terminal_size.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'backports.shutil_get_terminal_size.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/h9i48gy37m221wb3005j5rv0nmgg1043-python2.7-backports.shutil_get_terminal_size-unstable-2016-02-21

GrahamcOfBorg · 2018-07-02T15:55:24Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.backports_shutil_get_terminal_size

The following builds were skipped because they don't evaluate on aarch64-linux: python3.pkgs.backports_shutil_get_terminal_size

Partial log (click to expand)

reading manifest file 'backports.shutil_get_terminal_size.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'backports.shutil_get_terminal_size.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/ac8wm859rz605vman44rhyv6kazpci7z-python2.7-backports.shutil_get_terminal_size-unstable-2016-02-21

timokau requested a review from FRidh as a code owner July 1, 2018 15:39

GrahamcOfBorg added 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Jul 1, 2018

dotlambda reviewed Jul 1, 2018

View reviewed changes

timokau force-pushed the backports-master branch from 4df541d to c7784cd Compare July 1, 2018 23:01

dotlambda reviewed Jul 1, 2018

View reviewed changes

timokau force-pushed the backports-master branch from c7784cd to 091dc80 Compare July 2, 2018 15:07

pythonPackages.backports_shutil_get_terminal_size: 1.0 -> 2016-02-21

091dc80

dotlambda merged commit dcc1013 into NixOS:master Jul 2, 2018

timokau deleted the backports-master branch July 2, 2018 16:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.backports_shutil_get_terminal_size: 1.0 -> 2018-06-30 #42840

pythonPackages.backports_shutil_get_terminal_size: 1.0 -> 2018-06-30 #42840

timokau commented Jul 1, 2018 •

edited

dotlambda Jul 1, 2018

timokau Jul 1, 2018

dotlambda Jul 1, 2018

dotlambda Jul 1, 2018

dotlambda Jul 1, 2018

timokau Jul 1, 2018

dotlambda Jul 1, 2018

dotlambda Jul 1, 2018

timokau Jul 2, 2018

dotlambda Jul 1, 2018

dotlambda commented Jul 2, 2018

GrahamcOfBorg commented Jul 2, 2018

GrahamcOfBorg commented Jul 2, 2018

dotlambda commented Jul 2, 2018

GrahamcOfBorg commented Jul 2, 2018

GrahamcOfBorg commented Jul 2, 2018

pythonPackages.backports_shutil_get_terminal_size: 1.0 -> 2018-06-30 #42840

pythonPackages.backports_shutil_get_terminal_size: 1.0 -> 2018-06-30 #42840

Conversation

timokau commented Jul 1, 2018 • edited

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda commented Jul 2, 2018

GrahamcOfBorg commented Jul 2, 2018

GrahamcOfBorg commented Jul 2, 2018

dotlambda commented Jul 2, 2018

GrahamcOfBorg commented Jul 2, 2018

GrahamcOfBorg commented Jul 2, 2018

timokau commented Jul 1, 2018 •

edited