Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: missing codegen cast from metaclass union to virtual metaclass #6307

Merged
merged 1 commit into from Jul 2, 2018
Merged

Fix: missing codegen cast from metaclass union to virtual metaclass #6307

merged 1 commit into from Jul 2, 2018

Conversation

asterite
Copy link
Member

@asterite asterite commented Jul 1, 2018

Fixes #6298

This case was missing when we removed the cast from a union type to the base type in the hierarchy, which also applies to metaclasses.

@ysbaddaden ysbaddaden merged commit b8d64a7 into crystal-lang:master Jul 2, 2018
@RX14 RX14 added this to the Next milestone Jul 2, 2018
@asterite asterite deleted the bug/6298-cast-metaclass-union-to-virtual-metaclass branch July 6, 2018 22:57
@RX14 RX14 modified the milestones: Next, 0.26.0 Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardiff bcardiff bcardiff approved these changes

Assignees
No one assigned
Labels
kind:bug topic:compiler
Projects
None yet
Milestone
0.26.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asterite @bcardiff @ysbaddaden @RX14