disallow opaque as a return type of fn type syntax

andrewrk · andrewrk · commit 8fd7cc11e167 · 2018-06-18T11:12:15.000-04:00
closes #1115
diff --git a/src/analyze.cpp b/src/analyze.cpp
@@ -1022,6 +1022,7 @@ TypeTableEntry *get_fn_type(CodeGen *g, FnTypeId *fn_type_id) {
         ensure_complete_type(g, fn_type_id->return_type);
         if (type_is_invalid(fn_type_id->return_type))
             return g->builtin_types.entry_invalid;
+        assert(fn_type_id->return_type->id != TypeTableEntryIdOpaque);
     } else {
         zig_panic("TODO implement inferred return types https://github.com/ziglang/zig/issues/447");
     }
diff --git a/src/ir.cpp b/src/ir.cpp
@@ -18676,6 +18676,11 @@ static TypeTableEntry *ir_analyze_instruction_fn_proto(IrAnalyze *ira, IrInstruc
     fn_type_id.return_type = ir_resolve_type(ira, return_type_value);
     if (type_is_invalid(fn_type_id.return_type))
         return ira->codegen->builtin_types.entry_invalid;
+    if (fn_type_id.return_type->id == TypeTableEntryIdOpaque) {
+        ir_add_error(ira, instruction->return_type,
+            buf_sprintf("return type cannot be opaque"));
+        return ira->codegen->builtin_types.entry_invalid;
+    }
 
     if (fn_type_id.cc == CallingConventionAsync) {
         if (instruction->async_allocator_type_value == nullptr) {
diff --git a/test/compile_errors.zig b/test/compile_errors.zig
@@ -1,6 +1,15 @@
 const tests = @import("tests.zig");
 
 pub fn addCases(cases: *tests.CompileErrorContext) void {
+    cases.add(
+        "use c_void as return type of fn ptr",
+        \\export fn entry() void {
+        \\    const a: fn () c_void = undefined;
+        \\}
+    ,
+        ".tmp_source.zig:2:20: error: return type cannot be opaque",
+    );
+
     cases.add(
         "non int passed to @intToFloat",
         \\export fn entry() void {
@@ -9,6 +18,7 @@ pub fn addCases(cases: *tests.CompileErrorContext) void {
     ,
         ".tmp_source.zig:2:32: error: expected int type, found 'comptime_float'",
     );
+
     cases.add(
         "use implicit casts to assign null to non-nullable pointer",
         \\export fn entry() void {

Original file line number	Diff line number	Diff line change
`@@ -1022,6 +1022,7 @@ TypeTableEntry get_fn_type(CodeGen g, FnTypeId *fn_type_id) {`
`1022`	`1022`	`ensure_complete_type(g, fn_type_id->return_type);`
`1023`	`1023`	`if (type_is_invalid(fn_type_id->return_type))`
`1024`	`1024`	`return g->builtin_types.entry_invalid;`
	`1025`	`+ assert(fn_type_id->return_type->id != TypeTableEntryIdOpaque);`
`1025`	`1026`	`} else {`
`1026`	`1027`	`zig_panic("TODO implement inferred return types https://github.com/ziglang/zig/issues/447");`
`1027`	`1028`	`}`