Fix File.extname for filenames like "a.yml", and make the method easier to understand #6217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, nevermind. It should be done like in Go: https://golang.org/src/path/filepath/path.go?s=6131:6159#L207 |
|
(But I won't send a PR, so someone should do that. Probably going byte per byte, in reverse, over the slice, should work, but it's a boring thing to work on for me) |
|
@asterite This is actually already implemented in #5635 as Path#extension. This could be backported as bugfix for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6215
Alternative to #6216, which probably works, but please try to explain me in words what this means:
The regression was probably introduced because the code became hard to understand, practically unreadable. It's better to have small concise checks with comments, so that anyone can quickly understand what the code does.