Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DONT MERGE: Revert "treewide: http -> https sources (#42676)" #42821

Closed
wants to merge 1 commit into from
Closed

DONT MERGE: Revert "treewide: http -> https sources (#42676)" #42821

wants to merge 1 commit into from

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Jun 30, 2018

This reverts commit 57bccb3.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@zimbatm zimbatm requested a review from peti as a code owner June 30, 2018 14:56
@zimbatm zimbatm requested a review from grahamc June 30, 2018 14:56
@zimbatm
Copy link
Member Author

zimbatm commented Jun 30, 2018

Just testing the ofborg evaluator

@zimbatm zimbatm changed the title Revert "treewide: http -> https sources (#42676)" DONT MERGE: Revert "treewide: http -> https sources (#42676)" Jun 30, 2018
@grahamc
Copy link
Member

grahamc commented Jun 30, 2018

@GrahamcOfBorg eval

@grahamc grahamc closed this Jun 30, 2018
@grahamc grahamc mentioned this pull request Jun 30, 2018
Closed
@zimbatm zimbatm deleted the ofborg-stdenv-test-2 branch July 1, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
6.topic: printing 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zimbatm @grahamc @GrahamcOfBorg