New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haskell generic-builder: Yet more cross fixes #42247
haskell generic-builder: Yet more cross fixes #42247
Conversation
It targets the build platform.
This looks good but please don't merge until we can figure out the libiconv in iOS. |
This is very interesting, because today I discovered that after updating the channel I no longer can build even a trivial program that uses
|
If there are problems, cross or native, with base libraries, we should solve them another way.#42069 should cover. |
@kirelagin Did you solve this problem? |
@mpickering No, but I do plan to work on it this week, you can follow #42069. |
I would suggest this be reverted until the problems are resolved. |
arg max problems? I don't think this one is to blame, is it? |
It could be actually which is very unfortunate because the depsBuildBuild things is definitely correct. |
This patch is responsible for the problems mentioned in #42247 (comment) according to @kirelagin |
@mpickering But are you sure it's not the separate setup db thing? That seemed much more likely to me. |
I am not sure. I tried reverting the patch but it caused a lot of rebuilding so I haven't been able to confirm yet. |
You should try this branch if you have a free machine & some extra time: https://github.com/matthewbauer/nixpkgs/tree/ghc-macos-argmax-fix |
@matthewbauer Starting the builds now... |
Motivation for this change
nativeGhc
targets the build platform so it should be adepsBuildBuild
. This is more important because GHC propagates some dependencies, and we want those to be propagated properly.The
--extra-*
flags are only for host dependencies. They ought to be harmless when given others as the linker can just skip, but we ran into some issue indicating otherwise. Best to preemptively fix.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)CC @kirelagin @angerman