Libprefixed to multioutput/heimdal #42295
Conversation
| find $out/bin -type f | grep -v 'krb5-config' | xargs rm | ||
| preConfigure = '' | ||
| configureFlagsArray+=( | ||
| "--bindir=$out/bin" # Put binaries to $out, then move them to $bin, |
There was a problem hiding this comment.
Are you sure what you're doing is safe then?
There was a problem hiding this comment.
Possible one of binaries referenced by libs, and it created cross reference, I make one more try to figure out, which binary does it.
There was a problem hiding this comment.
@dezgeg well, I found source libkrb5 have some inner macro processor, which able to expand %{BINDIR} so we have $out (aka lib) refer to $bin.
So we have 2 options:
- patch out BINDIR and SBINDIR tokens from macro
- keep current solution (put all to $out and sort later in
postInstall)
There was a problem hiding this comment.
@dezgeg so do you have any idea which option is better? I'd like to have it merged sometimes ;)
There was a problem hiding this comment.
Sounds like the safest thing to do is to have both binaries and libraries in $out then.
There was a problem hiding this comment.
So could you find a time, and review/merge please?
| @@ -76,14 +66,27 @@ stdenv.mkDerivation rec { | |||
| (cd lib/hcrypto; make -j $NIX_BUILD_CORES) | |||
| ''; | |||
|
|
|||
| # FIXME: share/info hits $bin, IDK why, but I decide is to minor to block | |||
There was a problem hiding this comment.
You can add an info output for the info pages.
avnik
force-pushed
the
libprefixed-to-multioutput/heimdal
branch
from
4fd3bfe
to
73d8d33
Compare
| @@ -21,53 +16,49 @@ stdenv.mkDerivation rec { | |||
| sha256 = "1j38wjj4k0q8vx168k3d3k0fwa8j1q5q8f2688nnx1b9qgjd6w1d"; | |||
| }; | |||
|
|
|||
| outputs = [ "out" "bin" "dev" "man" "info" ]; | |||
There was a problem hiding this comment.
I would just leave out the bin output. It is fine to have binaries in out.
|
On Mon, Jul 23, 2018 at 08:17:09AM -0700, Matthew Bauer wrote:
matthewbauer commented on this pull request.
> @@ -21,53 +16,49 @@ stdenv.mkDerivation rec {
sha256 = "1j38wjj4k0q8vx168k3d3k0fwa8j1q5q8f2688nnx1b9qgjd6w1d";
};
+ outputs = [ "out" "bin" "dev" "man" "info" ];
I would just leave out the bin output. It is fine to have binaries in out.
Ok, I do it on this week.
|
avnik
force-pushed
the
libprefixed-to-multioutput/heimdal
branch
from
73d8d33
to
e0a6e41
Compare
avnik
force-pushed
the
libprefixed-to-multioutput/heimdal
branch
from
e0a6e41
to
e808b7d
Compare
|
@matthewbauer done everything month ago ;) May be time to finish it? |
|
Sorry - forgot about this. Looks good! |
Motivation for this change
Say "farewell" to long-lived ad-hoc hack, when we had two derivations for one package -- one for library-only version, second one with programs and daemons built.
This PR contain finalized heimdal rework, factored out of #38494
(because it hard to maintain so long live branch, which cause significant local rebuild)
See #14693 for problem history and details.
Actually I haven't test
nixosservice module, because IDK how to run heimdal kerberos server.So some feedback for users welcomed. Applications which build against heimdal kerberos buildds and run (at least some of them, which I tried)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)