Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtiff: 2018-11-04 -> 4.0.10 #51105

Closed
wants to merge 1 commit into from
Closed

libtiff: 2018-11-04 -> 4.0.10 #51105

wants to merge 1 commit into from

Conversation

andrew-d
Copy link
Contributor

Motivation for this change

Security updates (#49786)

This is a followup to #49860 that switches back to a released version, and updates to 4.0.10 to fix CVE-2018-18661. The Debian patchset that we applied prior to #49860 (link) doesn't contain any security updates or bugfixes (just a typo fix, see here), so I didn't re-add those.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @ckauhaus

@c0bw3b c0bw3b added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 27, 2018
Ekleog
Ekleog approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@Ekleog Ekleog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase this against staging-next? The RFC states that mass-rebuild security fixes should go there, to reduce its time-to-upstream :)

@Ekleog
Copy link
Member

Ekleog commented Nov 28, 2018

Actually nevermind, I've cherry-picked your commit to both staging-next and release-18.09. But next time it'd be convenient if the PR was done against staging-next for security fixes (staging is for regular mass-rebuilds) with a PR including a backport to release-18.09 using git cherry-pick -x.

Anyway, thank you for your reactivity in handling this update!

Cherry-pick commits: ac3b358 and 6ea49f6.

@Ekleog Ekleog closed this Nov 28, 2018
@Ekleog Ekleog mentioned this pull request Nov 28, 2018
Closed
9 tasks
@andrew-d andrew-d deleted the andrew/libtiff-4.0.10 branch December 28, 2018 20:06
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
@FliegendeWurst FliegendeWurst mentioned this pull request Feb 20, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekleog Ekleog Ekleog approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andrew-d @Ekleog @c0bw3b @GrahamcOfBorg @TredwellGit