Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.buildDunePackage: fix meta.platforms #51115

Merged
merged 1 commit into from Nov 30, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 27, 2018

Motivation for this change

The standard meta attribute is spelled platforms (https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes).

Also, // does not merge nested attribute sets (https://nixos.org/nix/manual/#sec-language-operators).

cc/@Zimmi48, author.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl vbgl merged commit 66efb76 into NixOS:master Nov 30, 2018
@vbgl vbgl deleted the dune-platforms branch November 30, 2018 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants