Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gist: 4.6.2 -> 5.0.0, simplify #51114

Merged
merged 1 commit into from
Nov 27, 2018
Merged

gist: 4.6.2 -> 5.0.0, simplify #51114

merged 1 commit into from
Nov 27, 2018
+3 −13

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Nov 27, 2018

  • default wrapper works fine now AFAICT
  • Not sure that 'dontStrip' does anything here
    (regardless doesn't seem to be useful any longer)
Motivation for this change

Apologies for not linking changelog-- didn't find one but probably
could have searched more thoroughly O:).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@dtzWill
gist: 4.6.2 -> 5.0.0, simplify
97c8ede 
* default wrapper works fine now AFAICT
* Not sure that 'dontStrip' does anything here
  (regardless doesn't seem to be useful any longer)
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gist

Partial log (click to expand)

  Build root: /
  Bin dir: /nix/store/r6yjybi1gbnj5jrc7k17r64kga7vl89m-gist-5.0.0/lib/ruby/gems/2.5.0/bin
  Gem home: /nix/store/r6yjybi1gbnj5jrc7k17r64kga7vl89m-gist-5.0.0/lib/ruby/gems/2.5.0
Successfully installed gist-5.0.0
1 gem installed
post-installation fixup
patching script interpreter paths in /nix/store/r6yjybi1gbnj5jrc7k17r64kga7vl89m-gist-5.0.0
/nix/store/r6yjybi1gbnj5jrc7k17r64kga7vl89m-gist-5.0.0/lib/ruby/gems/2.5.0/gems/gist-5.0.0/bin/gist: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/l977nffsm9vikszj4znjlnhgg57gzdc1-ruby-2.5.3/bin/ruby"
/nix/store/r6yjybi1gbnj5jrc7k17r64kga7vl89m-gist-5.0.0/lib/ruby/gems/2.5.0/gems/gist-5.0.0/build/gist: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/l977nffsm9vikszj4znjlnhgg57gzdc1-ruby-2.5.3/bin/ruby"
/nix/store/r6yjybi1gbnj5jrc7k17r64kga7vl89m-gist-5.0.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gist

Partial log (click to expand)

  Gem home: /nix/store/fpclz1xw63whxwvqx79vnsbm2kszx20r-gist-5.0.0/lib/ruby/gems/2.5.0
Successfully installed gist-5.0.0
1 gem installed
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fpclz1xw63whxwvqx79vnsbm2kszx20r-gist-5.0.0
patching script interpreter paths in /nix/store/fpclz1xw63whxwvqx79vnsbm2kszx20r-gist-5.0.0
/nix/store/fpclz1xw63whxwvqx79vnsbm2kszx20r-gist-5.0.0/lib/ruby/gems/2.5.0/gems/gist-5.0.0/build/gist: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/ika1q830fhx778vdrnpbpsz2a4386yl6-ruby-2.5.3/bin/ruby"
/nix/store/fpclz1xw63whxwvqx79vnsbm2kszx20r-gist-5.0.0/lib/ruby/gems/2.5.0/gems/gist-5.0.0/bin/gist: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/ika1q830fhx778vdrnpbpsz2a4386yl6-ruby-2.5.3/bin/ruby"
checking for references to /build in /nix/store/fpclz1xw63whxwvqx79vnsbm2kszx20r-gist-5.0.0...
/nix/store/fpclz1xw63whxwvqx79vnsbm2kszx20r-gist-5.0.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gist

Partial log (click to expand)

  Gem home: /nix/store/ryfh1xd5zq3vifx54vvsnnzak1w4vdjp-gist-5.0.0/lib/ruby/gems/2.5.0
Successfully installed gist-5.0.0
1 gem installed
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ryfh1xd5zq3vifx54vvsnnzak1w4vdjp-gist-5.0.0
patching script interpreter paths in /nix/store/ryfh1xd5zq3vifx54vvsnnzak1w4vdjp-gist-5.0.0
/nix/store/ryfh1xd5zq3vifx54vvsnnzak1w4vdjp-gist-5.0.0/lib/ruby/gems/2.5.0/gems/gist-5.0.0/build/gist: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/caf5a0v9s94j17z3f8db6jjhysdpa0j8-ruby-2.5.3/bin/ruby"
/nix/store/ryfh1xd5zq3vifx54vvsnnzak1w4vdjp-gist-5.0.0/lib/ruby/gems/2.5.0/gems/gist-5.0.0/bin/gist: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/caf5a0v9s94j17z3f8db6jjhysdpa0j8-ruby-2.5.3/bin/ruby"
checking for references to /build in /nix/store/ryfh1xd5zq3vifx54vvsnnzak1w4vdjp-gist-5.0.0...
/nix/store/ryfh1xd5zq3vifx54vvsnnzak1w4vdjp-gist-5.0.0

worldofpeace
worldofpeace approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still able to create gists with this tool 👍

@worldofpeace worldofpeace merged commit 8072eea into NixOS:master Nov 27, 2018
@worldofpeace
Copy link
Contributor

Couldn't find a changelog but a github compare on the repo can be helpful defunkt/gist@v4.6.2...v5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @worldofpeace