Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dolphin: enable wayland #51098

Merged
merged 1 commit into from Nov 27, 2018
Merged

dolphin: enable wayland #51098

merged 1 commit into from Nov 27, 2018

Conversation

colemickens
Copy link
Member

Motivation for this change

This probably ought to be systematically done for most (all?) qt/kde packages, but I only use and can test dolphin, so just doing this for now.

Tested under sway.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ekleog
Copy link
Member

Ekleog commented Nov 27, 2018

@GrahamcOfBorg build dolphin

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dolphin

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dolphin

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/mhpi8ry5zv7iizylyd56axqxl4k4ba9a-dolphin-18.08.1/lib  /nix/store/mhpi8ry5zv7iizylyd56axqxl4k4ba9a-dolphin-18.08.1/bin
patching script interpreter paths in /nix/store/mhpi8ry5zv7iizylyd56axqxl4k4ba9a-dolphin-18.08.1
checking for references to /build in /nix/store/mhpi8ry5zv7iizylyd56axqxl4k4ba9a-dolphin-18.08.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/kw7blq99rf6q6v1srjyhv9rqzhcbxd49-dolphin-18.08.1-dev
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kw7blq99rf6q6v1srjyhv9rqzhcbxd49-dolphin-18.08.1-dev/lib
patching script interpreter paths in /nix/store/kw7blq99rf6q6v1srjyhv9rqzhcbxd49-dolphin-18.08.1-dev
checking for references to /build in /nix/store/kw7blq99rf6q6v1srjyhv9rqzhcbxd49-dolphin-18.08.1-dev...
postPatchMkspecs
postPatchMkspecs

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dolphin

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/s3h3cwkghlsf117nbvnnxrc1y6p4bh2p-dolphin-18.08.1/lib  /nix/store/s3h3cwkghlsf117nbvnnxrc1y6p4bh2p-dolphin-18.08.1/bin
patching script interpreter paths in /nix/store/s3h3cwkghlsf117nbvnnxrc1y6p4bh2p-dolphin-18.08.1
checking for references to /build in /nix/store/s3h3cwkghlsf117nbvnnxrc1y6p4bh2p-dolphin-18.08.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/bsbdbbnjp2ldng24g1d32zkypzc955gd-dolphin-18.08.1-dev
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bsbdbbnjp2ldng24g1d32zkypzc955gd-dolphin-18.08.1-dev/lib
patching script interpreter paths in /nix/store/bsbdbbnjp2ldng24g1d32zkypzc955gd-dolphin-18.08.1-dev
checking for references to /build in /nix/store/bsbdbbnjp2ldng24g1d32zkypzc955gd-dolphin-18.08.1-dev...
postPatchMkspecs
postPatchMkspecs

@Ekleog
Copy link
Member

Ekleog commented Nov 27, 2018

Thank you! I can also confirm that it still runs correctly after this change on a regular Xorg host :)

cc @ttuegel as package maintainer for posterity, I'm going to go ahead and merge this for now, as it looks harmless.

@Ekleog Ekleog merged commit 507adac into NixOS:master Nov 27, 2018
@colemickens colemickens deleted the dolphin branch January 30, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@colemickens @Ekleog @GrahamcOfBorg