Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document upgrading Ruby packages #51111

Merged
merged 1 commit into from Nov 28, 2018
Merged

doc: document upgrading Ruby packages #51111

merged 1 commit into from Nov 28, 2018

Conversation

alyssais
Copy link
Member

Motivation for this change

As requested by @Ekleog in #51040 (comment).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Ekleog
Ekleog requested changes Nov 28, 2018
View reviewed changes
Copy link
Member

@Ekleog Ekleog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

doc/languages-frameworks/ruby.xml Outdated
<![CDATA[$ cd pkgs/servers/monitoring/sensu
$ nix-shell -p bundler --run 'bundle lock --update'
$ nix-shell -p bundix --run 'bundix'
}]]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a dangling } brace here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, copy/paste error.

@Ekleog
Copy link
Member

Ekleog commented Nov 28, 2018

Thank you! For the record, I spotted the } by reading the generated documentation with nix-build doc && firefox ./result/share/doc/nixpkgs/manual.html :)

@Ekleog Ekleog merged commit 6bda83a into NixOS:master Nov 28, 2018
@alyssais alyssais deleted the docs_ruby_update branch December 5, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekleog Ekleog Ekleog approved these changes

Assignees
No one assigned
Labels
6.topic: ruby 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alyssais @Ekleog @GrahamcOfBorg