Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minc2-simple: init at 2018-12-20 #51094

Closed
wants to merge 3 commits into from
Closed

minc2-simple: init at 2018-12-20 #51094

wants to merge 3 commits into from

Conversation

bcdarwin
Copy link
Member

Motivation for this change

Adds the C and Python parts of the minc2-simple library (and one associated script) in separate expressions.

The tests for the C library seem to be broken but the Python tests succeed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [NA] Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin bcdarwin requested a review from FRidh as a code owner November 27, 2018 05:16
@bcdarwin bcdarwin changed the title minc2-simple: init at 2.1 minc2-simple: init at 2018-12-20 Jan 4, 2019
@bcdarwin
Copy link
Member Author

bcdarwin commented Jan 4, 2019

Looks like this PR was initially ignored due to a merge conflict? Anyway, fixed, patches merged upstream, bumped to latest Git commit.

@FRidh

FRidh
FRidh requested changes Jan 5, 2019
View reviewed changes
pkgs/development/libraries/libminc/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/minc2-simple/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/minc2-simple/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/minc2-simple/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/minc2-simple/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/minc2-simple/default.nix Outdated Show resolved Hide resolved
@bcdarwin
Copy link
Member Author

bcdarwin commented Jan 5, 2019

Everything resolved.

@bcdarwin
Copy link
Member Author

@FRidh this has picked up a trivial merge conflict from sitting around but otherwise should be fine to merge.

@bcdarwin bcdarwin closed this Oct 26, 2019
@bcdarwin bcdarwin mentioned this pull request Oct 26, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @FRidh @GrahamcOfBorg