New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
systrayhelper: 0.0.4 -> 0.0.5 #51652
Conversation
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/using-xvfb-in-checkphase/1497/4 |
Is this a WIP? Otherwise, you need remove commented out code / todos ( |
@rasendubi: indeed an oversight, thanks! I'll try to add the ffmpeg record mechanics in pre/postCheckHook so that I can use them through an override from the source. |
(triage) @cryptix any updates? do you need any help? |
f5a72f1
to
b831bec
Compare
@rasendubi sorry, yes/no. this mostly got dragged behind. I pushed a rebased and cleaned up version. I moved the commented stuff to export test video recordings into the override.nix in the source of the project to unclutter this one. Also removed the deps.nix file since this uses vendored dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments. Otherwise, it looks good.
When you think PR is ready for the final review and merge, remove [WIP]
from the title.
b831bec
to
a28276b
Compare
updated to respect review comments and rebased on master. |
@GrahamcOfBorg build systrayhelper |
nix-review fails for me with the following error:
I think |
I'm closing as CI fails and OP seems to not care as for making this update work and to much time has passed. |
Motivation for this change
updates to the latest release v0.0.5 which includes some fixes and dependency updates.
also includes a checkPhase using xvfb_run to spawn go test, which starts i3 and the helper and then uses xdotool to send clicks back to the helper
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)