Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoom-us: 2.5.146186.1130 -> 2.6.146750.1204 #51662

Merged
merged 1 commit into from Dec 8, 2018
Merged

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Dec 7, 2018

Motivation for this change

Regular version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor Author

srhb commented Dec 7, 2018

I'll test functionality today.

@srhb
Copy link
Contributor Author

srhb commented Dec 8, 2018

Everything seems fine. :)

@Mic92 Mic92 merged commit 477d535 into NixOS:master Dec 8, 2018
@Mic92
Copy link
Member

Mic92 commented Dec 8, 2018

Does this need a backport as this depends on external services?

srhb added a commit to srhb/nixpkgs that referenced this pull request Dec 10, 2018
(cherry picked from commit 8b3949d)
Backport of NixOS#51662
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants