New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.tlslite-ng: init at 0.7.5, migrate tlslite references to it, delete tlslite #51664
Conversation
9f7182c
to
52825fc
Compare
I'm not familiar with development on macOS so I would appreciate any help in making sure that tlslite-ng continues to work there: tlsfuzzer/tlslite-ng#73 (in general, it should work as I try to use portable code, but it will be easier for you if the issues are caught early, not after release) |
I don't think it's wise to leave a security-relevant package in that it is expected to remain unmaintained.. |
If the package is unmaintained and not used by anything, I don't think it should be in Nixpkgs at all. I'd prefer the derivation be deleted. It's never going to be fixed, (and in fact, since it's security-relevant, never should be fixed since it's unmaintained), so there's no benefit for us to continue to carry the code. |
Thanks for the feedback. Personally I'd prefer to delete |
I think the normal way to do this is to delete the package and then add an alias to I’d prefer that we don’t just alias this to the ng version, because then it’s not clear what libraries a derivation is actually using. |
I'll take the argument against aliasing, though if we end up having to backport for a security issue, it should get aliased over in the backport. |
…e-ng tlslite has a test failure on Python 3.7 [0]. @tomato42, a commiter of tlslite and author of tlslite-ng said, that tlslite is abandoned (last commit 2015) and tlslite-ng should be used as a drop in replacement. [0] trevp/tlslite#121
52825fc
to
93bf0a0
Compare
@GrahamcOfBorg build pythonPackages.tlslite-ng python3Packages.tlslite-ng |
Motivation for this change
pythonPackages.tlslite
has a test failure on Python 3.7. @tomato42, a commiter of tlslite and author of tlslite-ng said, that tlslite is abandoned (last commit 2015) and tlslite-ng should be used as a drop in replacement.As it doesn't seem to be adopted widely, I believe that it is suitable to mark
tlslite
as broken.tlslite-ng
can be dropped-in without much of a hassle.Things done
pythonPackages.tlslite-ng
tlslite
as brokentlslite
totlslite-ng
.sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)