Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.tlslite-ng: init at 0.7.5, migrate tlslite references to it, delete tlslite #51664

Merged
merged 2 commits into from Dec 10, 2018

Conversation

erictapen
Copy link
Member

Motivation for this change

pythonPackages.tlslite has a test failure on Python 3.7. @tomato42, a commiter of tlslite and author of tlslite-ng said, that tlslite is abandoned (last commit 2015) and tlslite-ng should be used as a drop in replacement.

As it doesn't seem to be adopted widely, I believe that it is suitable to mark tlslite as broken. tlslite-ng can be dropped-in without much of a hassle.

Things done
  • Init pythonPackages.tlslite-ng
  • Mark tlslite as broken
  • Migrate all occurences of tlslite to tlslite-ng.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tomato42
Copy link

tomato42 commented Dec 7, 2018

I'm not familiar with development on macOS so I would appreciate any help in making sure that tlslite-ng continues to work there: tlsfuzzer/tlslite-ng#73 (in general, it should work as I try to use portable code, but it will be easier for you if the issues are caught early, not after release)

@edef1c
Copy link
Member

edef1c commented Dec 10, 2018

I don't think it's wise to leave a security-relevant package in that it is expected to remain unmaintained..
We should at least have a comment explaining why the package is broken (and should not be used), or perhaps alias the old package name over.

@alyssais
Copy link
Member

If the package is unmaintained and not used by anything, I don't think it should be in Nixpkgs at all. I'd prefer the derivation be deleted. It's never going to be fixed, (and in fact, since it's security-relevant, never should be fixed since it's unmaintained), so there's no benefit for us to continue to carry the code.

@erictapen
Copy link
Member Author

Thanks for the feedback. Personally I'd prefer to delete tlslite as well. As this change only affects master, I'd think we could delete it right away? People missing the package for their projects could be told (via the commit message), that they should use tlslite-ng. Or is there any mechanism like the deprecation warning for module options for packages?

@alyssais
Copy link
Member

I think the normal way to do this is to delete the package and then add an alias to throw “foo has been removed because bar. use baz instead”.

I’d prefer that we don’t just alias this to the ng version, because then it’s not clear what libraries a derivation is actually using.

@edef1c
Copy link
Member

edef1c commented Dec 10, 2018

I'll take the argument against aliasing, though if we end up having to backport for a security issue, it should get aliased over in the backport.
I can find some precedent (8 instances) in nixpkgs for throw "deprecated 2018-12-10: use tlslite-ng instead";

…e-ng

tlslite has a test failure on Python 3.7 [0]. @tomato42, a commiter of
tlslite and author of tlslite-ng said, that tlslite is abandoned (last
commit 2015) and tlslite-ng should be used as a drop in replacement.

[0] trevp/tlslite#121
@erictapen erictapen changed the title pythonPackages.tlslite-ng: init at 0.7.5, migrate tlslite references to it. pythonPackages.tlslite-ng: init at 0.7.5, migrate tlslite references to it, delete tlslite Dec 10, 2018
@alyssais
Copy link
Member

@GrahamcOfBorg build pythonPackages.tlslite-ng python3Packages.tlslite-ng

@edef1c edef1c merged commit 995d224 into NixOS:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants