Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opusTools: 0.1.10 -> 0.2 #51665

Merged
merged 1 commit into from Dec 7, 2018
Merged

opusTools: 0.1.10 -> 0.2 #51665

merged 1 commit into from Dec 7, 2018

Conversation

pmiddend
Copy link
Contributor

@pmiddend pmiddend commented Dec 7, 2018

Motivation for this change

Now that libopusenc is in nixpkgs, we can upgrade opus-tools, too!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member

alyssais commented Dec 7, 2018

@GrahamcOfBorg build opus-tools

@alyssais
Copy link
Member

alyssais commented Dec 7, 2018

@GrahamcOfBorg build opusTools

@alyssais
Copy link
Member

alyssais commented Dec 7, 2018

@pmiddend would you mind updating your commit message to use the correct attribute name?

@pmiddend
Copy link
Contributor Author

pmiddend commented Dec 7, 2018

@alyssais Good catch! Fixed that.

@pmiddend pmiddend changed the title opus-tools: 0.1.10 -> 0.2 opusTools: 0.1.10 -> 0.2 Dec 7, 2018
@alyssais alyssais merged commit 21ed8b1 into NixOS:master Dec 7, 2018
@pmiddend pmiddend deleted the opus-tools-0.1.10-to-0.2 branch December 7, 2018 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmiddend @alyssais @GrahamcOfBorg