Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: set machines fqdn in /etc/hosts #51661

Merged
merged 1 commit into from Jan 12, 2019
Merged

test: set machines fqdn in /etc/hosts #51661

merged 1 commit into from Jan 12, 2019

Conversation

eonpatapon
Copy link
Contributor

Motivation for this change

The contents in /etc/hosts should follow the format <ip> <fqdn> [<alias>, ...]

IMO, if a domain is configured for the machine, machine.domain should be resolvable and not just machine.

It also help in test cases with multiple VMs where applications are using fqdn name to talk to each other.

I don't think this change will have some impact on existing tests but to be sure it would require to run them all. (not sure how to do that either) WDYT ?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aszlig
aszlig approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@aszlig aszlig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrahamcOfBorg test kubernetes.dns kubernetes.rbac

These are the only tests that are currently affected by this, because all other tests do not set networking.domain.

@infinisil
Copy link
Member

I'm missing the point of doing this. Why did you decide to PR this?

@eonpatapon
Copy link
Contributor Author

I have some tests with multiple VMs where the application wants to resolve fqdn names of machines. So instead of setting up a DNS server for this, it's easier to have them in /etc/hosts

infinisil
infinisil approved these changes Dec 30, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, this looks good to me then.

@infinisil
Copy link
Member

infinisil commented Dec 30, 2018 •
edited

The kubernetes tests seems to be broken for me, but I guess that has nothing to do with this PR

$ nix-build nixos/release.nix -A tests.kubernetes.dns
error: anonymous function at /home/infinisil/src/nixpkgs/nixos/default.nix:1:1 called with unexpected argument 'config', at /home/infinisil/src/nixpkgs/nixos/tests/kubernetes/base.nix:3:10

Ah this got fixed in #51938

@infinisil infinisil merged commit 497e6f1 into NixOS:master Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aszlig aszlig aszlig approved these changes

@infinisil infinisil infinisil approved these changes

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eonpatapon @infinisil @aszlig @GrahamcOfBorg