Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handbrake: 1.1.2 -> 1.2.0 #52453

Merged
merged 7 commits into from Jan 11, 2019
Merged

handbrake: 1.1.2 -> 1.2.0 #52453

merged 7 commits into from Jan 11, 2019

Conversation

Anton-Latukha
Copy link
Contributor

@Anton-Latukha Anton-Latukha commented Dec 17, 2018 •
edited

Motivation for this change

Major update, switch from LibAV to FFMpeg & other changes (release notes).
Due to need in HandBrake compilation - nv-codec-headers bringed to top-level scope, and during that updated 8.1.24.2 -> 8.2.15.6.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Anton-Latukha Anton-Latukha force-pushed the handbrake-1.2 branch 2 times, most recently from da3b2b9 to d83abdb Compare December 25, 2018 02:06
@Anton-Latukha Anton-Latukha force-pushed the handbrake-1.2 branch 2 times, most recently from c7c55ee to 7f112a7 Compare December 27, 2018 15:59
@Anton-Latukha
Copy link
Contributor Author

Support of LibAV dropped.

Due to HandBrake having a lot of out-of-tree patches: folder.

Many of them seem like a good quality improvements. Some of them go upstream, some not.
It is not possible to track all their patches, and if we do - it would be essentially their bundle in the closure.

Some sort of official internal build instructions are:

  1. https://github.com/HandBrake/HandBrake/blob/master/pkg/linux/flatpak/fr.handbrake.ghb.json
  2. https://github.com/flathub/fr.handbrake.ghb/blob/master/fr.handbrake.ghb.json

External build extructions: https://handbrake.fr/docs/en/1.2.0/developer/build-linux.html

@Anton-Latukha Anton-Latukha changed the title [WIP] handbrake: 1.1.2 -> 1.2.0 handbrake: 1.1.2 -> 1.2.0 Dec 27, 2018
@Anton-Latukha
Copy link
Contributor Author

I would be happy to go through all major and minor notes about the code of the package.
I want to learn more.

@Anton-Latukha
Copy link
Contributor Author

Anton-Latukha commented Dec 27, 2018 •
edited

One of the considerations may be:
Instead of FFMpeg_4: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/libraries/ffmpeg/generic.nix. Since FFMpeg in Nix is:

nixpkgs/pkgs/development/libraries/ffmpeg/generic.nix

Line 23 in 830599d

* THIS IS A MINIMAL BUILD OF FFMPEG, do not include dependencies unless

To use FFMpeg-full: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/libraries/ffmpeg-full/default.nix

FFMpeg-full has more codecs/containers for input and more processing possibilities, which seems sane for the rich video transcoder.

@Anton-Latukha
Copy link
Contributor Author

Diff of FFMpeg-{full,4} closures is 100mb.

@Anton-Latukha
handbrake: 1.2.0: updating deps
fd8a90f 
rm yasm - dropped
rm bzip2, zlib - no needed for build
rm mp4v2, libmkv, mpeg2dec - drop abandonware, HandBrake now uses FFMpeg for that
add nasm, speex, nv-codec-headers - new required deps
@Anton-Latukha
handbrake: 1.2.0: ffmpeg_4 -> ffmpeg-full
6ebcbd0
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-december/1711/7

@FRidh
Copy link
Member

FRidh commented Jan 2, 2019

@GrahamcOfBorg eval

@Anton-Latukha
Copy link
Contributor Author

Anton-Latukha commented Jan 5, 2019 •
edited

@MP2E
Updated here handbrake to 1.2.0 requires nv-codec-headers for compilation.
The package was used internally in ffmpeg-full.
I moved the nv-codec-headers to the global NixPkgs file structure and top-level package scope.
Also updated nv-codec-headers 8.1.24.2 -> 8.2.15.6 if I am at it.

@Anton-Latukha
Copy link
Contributor Author

Everything is done.
It is pretty straight-forward PR.
Please, merge it.

@peterhoeg peterhoeg merged commit a9632dd into NixOS:master Jan 11, 2019
@Anton-Latukha Anton-Latukha deleted the handbrake-1.2 branch January 11, 2019 06:58
@uninsane uninsane mentioned this pull request Mar 25, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg peterhoeg left review comments

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Anton-Latukha @nixos-discourse @FRidh @matthewbauer @peterhoeg @GrahamcOfBorg