Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adoptopenjdk: autogenerate sources + add support for aarch64 #52454

Merged
merged 2 commits into from Dec 18, 2018
Merged

adoptopenjdk: autogenerate sources + add support for aarch64 #52454

merged 2 commits into from Dec 18, 2018

Conversation

bennofs
Copy link
Contributor

@bennofs bennofs commented Dec 17, 2018

Motivation for this change

This automatically generates all the source hashes for the latest adoptopenjdk builds using the API, making updates easier. Another benefit is that it becomes easy to add support for other architectures, in this case I added support for aarch64-linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) (only on linux, not darwin)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bennofs
Copy link
Contributor Author

bennofs commented Dec 17, 2018

/cc @taku0 maintainer of adoptopenjdk

@bennofs
Copy link
Contributor Author

bennofs commented Dec 17, 2018

@GrahamcOfBorg build adoptopenjdk-jre-hotspot-bin-11 adoptopenjdk-hotspot-bin-11 adoptopenjdk-openj9-bin-11 adoptopenjdk-jre-openj9-bin-11

@bennofs bennofs mentioned this pull request Dec 17, 2018
Closed
@taku0
Copy link
Contributor

taku0 commented Dec 18, 2018

Looks good 👍.

@dotlambda @bennofs
adoptopenjdk-bin: use python-withPackages for shebang
2385999 
Co-Authored-By: bennofs <benno.fuenfstueck@gmail.com>
@bennofs bennofs merged commit f2dfe8b into NixOS:master Dec 18, 2018
@bennofs bennofs deleted the aarch64-adoptopenjdk branch December 18, 2018 19:28
@FRidh
Copy link
Member

FRidh commented Dec 19, 2018

Reverted this in a9e654e because of a missing attribute.

FRidh added a commit that referenced this pull request Dec 19, 2018
@FRidh
Revert "adoptopenjdk: autogenerate sources + add support for aarch64 (#…
a9e654e 
…52454)"

This reverts commit f2dfe8b, reversing
changes made to e116aa1.

The `openj9` attribute is missing for `jre` in case of `mac`. This missing
attribute is now blocking the channels from updating.

cc @bennofs
@bennofs
Copy link
Contributor Author

bennofs commented Dec 19, 2018

@FRidh thanks for catching this, sorry for the breakage. I thought ofborg ensures evaluation.

@bennofs bennofs restored the aarch64-adoptopenjdk branch December 19, 2018 09:44
@FRidh
Copy link
Member

FRidh commented Dec 19, 2018

Failure: https://hydra.nixos.org/build/86016999

@bennofs bennofs mentioned this pull request Dec 19, 2018
Open
@bennofs
Copy link
Contributor Author

bennofs commented Dec 19, 2018

Fixed in 6972c43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bennofs @taku0 @FRidh @dotlambda @GrahamcOfBorg