Commits on Dec 18, 2018

1. nixos/testing: disallow special chars in machine names in network exp… …

   …ressions
   
   These names are referenced by Perl variables inside the testing
   frameworks which don't allow chars like `-` as character inside. An exemplary
   expression may look like this:
   
   ```
   {
     x11-vm = {
       services.xserver.enable = true;
     };
   }
   ```
   
   This expression evaluates, e.g. when running `nixos-build-vms`, but when
   trying to run `./result/bin/nixos-run-vms`, an error like this occurs:
   
   ```
   starting VDE switch for network 1
   running the VM test script
   error: Can't modify subtraction (-) in scalar assignment at (eval 17) line 1, at EOF
   Bareword "test" not allowed while "strict subs" in use at (eval 17) line 1.
   Can't modify subtraction (-) in scalar assignment at (eval 17) line 1, at EOF
   Bareword "test" not allowed while "strict subs" in use at (eval 17) line 1.
   vde_switch: EOF on stdin, cleaning up and exiting
   cleaning up
   ```
   
   This can be very confusing for beginners, this change breaks evaluation
   if such names are used for machines.

   

   Ma27 committed Dec 18, 2018
   Copy the full SHA

   113a6b9 View commit details

   Browse the repository at this point in the history

2. Merge pull request #46806 from Ma27/disallow-dash-separators-in-machi… …

   …ne-declarations
   
   nixos/testing: disallow special chars in machine names in network expressions

   

   fpletz committed Dec 18, 2018
   Copy the full SHA

   670c5ac View commit details

   Browse the repository at this point in the history