Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.megaparsec: disable tests on version 6.5 #52451

Closed
wants to merge 1 commit into from
Closed

haskellPackages.megaparsec: disable tests on version 6.5 #52451

wants to merge 1 commit into from

Conversation

cyounkins
Copy link
Contributor

Motivation for this change

Disables broken tests for Haskell megaparsec package 6.5

Hydra failure: https://hydra.nixos.org/build/85949393/nixlog/1
Upstream: mrkkrp/megaparsec#323
/cc ZHF #45960

Not tested, unsure how to do so.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

peti
peti requested changes Dec 18, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please disable the tests in release-18.09, but not in master- The master build has succeeded fine, and I am worried that the disabled test suite will not be re-enabled when the inevitable update to 7.x arrives soon.

@cyounkins
Copy link
Contributor Author

I don't understand what happened but I guess somebody kicked Hydra at https://hydra.nixos.org/build/85949393/ ? The link to the log that's in my post no longer contains the error! Because the test failure has a message like "Randomized with seed xxx" I think the test only fails for some seeds. I'll close this in 24 hours if no one pipes up.

@peti peti closed this Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti requested changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cyounkins @peti @GrahamcOfBorg