Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/shadow: create setuid wrapper for chsh #51270

Merged
merged 1 commit into from Jun 2, 2020
Merged

nixos/shadow: create setuid wrapper for chsh #51270

merged 1 commit into from Jun 2, 2020

Conversation

aneeshusa
Copy link
Contributor

@aneeshusa aneeshusa commented Nov 30, 2018 •
edited

Motivation for this change

This allows non-declarative users to change their login shells.
#41966 will make this possible
for declarative users as well if the system config explicitly allows it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

Why is this necessary? Preferably include this reason in the commit message

@Mic92
Copy link
Member

Mic92 commented Dec 2, 2018

Possible motivation: Let user change their preferred login shell.

@aneeshusa aneeshusa force-pushed the enable-setuid-wrapper-for-chsh branch from 5f704b0 to b9bcac5 Compare April 7, 2019 22:12
@aneeshusa
nixos/shadow: create setuid wrapper for chsh
925b028 
This allows non-declarative users to change their login shells.
NixOS#41966 will make this possible
for declarative users as well if the system config explicitly allows it.
@aneeshusa aneeshusa force-pushed the enable-setuid-wrapper-for-chsh branch from b9bcac5 to 925b028 Compare April 7, 2019 22:12
@typetetris typetetris mentioned this pull request Aug 30, 2019
Merged
8 tasks
@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@Mic92 Mic92 merged commit 53d0dc6 into NixOS:master Jun 2, 2020
@aneeshusa aneeshusa deleted the enable-setuid-wrapper-for-chsh branch January 7, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil left review comments

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aneeshusa @infinisil @Mic92 @GrahamcOfBorg