Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elasticsearch-curator: 5.5.4 -> 5.6.0 #51256

Merged
merged 2 commits into from Dec 13, 2018
Merged

elasticsearch-curator: 5.5.4 -> 5.6.0 #51256

merged 2 commits into from Dec 13, 2018

Conversation

basvandijk
Copy link
Member

@basvandijk basvandijk commented Nov 29, 2018 •
edited

Motivation for this change

https://github.com/elastic/curator/releases/tag/v5.6.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@basvandijk basvandijk mentioned this pull request Nov 29, 2018
Closed
@basvandijk
Copy link
Member Author

@FRidh care to review?

Note that the elasticsearch-curator test succeeds on my system.

@GrahamcOfBorg test elk.ELK-5 elk.ELK-6

@basvandijk
Copy link
Member Author

@FRidh the pythonPackages.certifi upgrade contained in this PR causes lots of rebuilds. A bit too much for my machine. What do you think is the best way to test this? Maybe we should have a python-updates branch ala haskell-updates with an associated jobset on hydra.

@basvandijk
Copy link
Member Author

BTW this is the diff between certifi 2018.08.24 and 2018.11.29.

@basvandijk basvandijk changed the base branch from master to staging December 13, 2018 20:01
@basvandijk basvandijk merged commit 9c53047 into NixOS:staging Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 8.has: module (update) 8.has: package (update) 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@basvandijk @GrahamcOfBorg