Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearch-curator: 5.5.4 -> 5.6.0 #51256

Merged
merged 2 commits into from
Dec 13, 2018

Conversation

basvandijk
Copy link
Member

@basvandijk basvandijk commented Nov 29, 2018

Motivation for this change

https://github.com/elastic/curator/releases/tag/v5.6.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@basvandijk basvandijk added 2.status: work-in-progress This PR isn't done 8.has: package (update) This PR updates a package to a newer version labels Nov 29, 2018
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 29, 2018
@basvandijk basvandijk force-pushed the elasticsearch-curator-5.6.0 branch from 3bf319e to e068dff Compare December 2, 2018 13:30
@basvandijk basvandijk removed the 2.status: work-in-progress This PR isn't done label Dec 2, 2018
@basvandijk
Copy link
Member Author

@FRidh care to review?

Note that the elasticsearch-curator test succeeds on my system.

@GrahamcOfBorg test elk.ELK-5 elk.ELK-6

@basvandijk
Copy link
Member Author

@FRidh the pythonPackages.certifi upgrade contained in this PR causes lots of rebuilds. A bit too much for my machine. What do you think is the best way to test this? Maybe we should have a python-updates branch ala haskell-updates with an associated jobset on hydra.

@basvandijk
Copy link
Member Author

BTW this is the diff between certifi 2018.08.24 and 2018.11.29.

@basvandijk basvandijk force-pushed the elasticsearch-curator-5.6.0 branch from e068dff to f603236 Compare December 13, 2018 19:10

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@basvandijk basvandijk force-pushed the elasticsearch-curator-5.6.0 branch from f603236 to 5d970e7 Compare December 13, 2018 20:01
@basvandijk basvandijk changed the base branch from master to staging December 13, 2018 20:01
@basvandijk basvandijk requested a review from zimbatm as a code owner December 13, 2018 20:01
@basvandijk basvandijk merged commit 9c53047 into NixOS:staging Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants