Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seafile-shared: backport newer minor version to fix build failures #51257

Merged
merged 2 commits into from Nov 30, 2018
Merged

seafile-shared: backport newer minor version to fix build failures #51257

merged 2 commits into from Nov 30, 2018

Conversation

schmittlauch
Copy link
Member

Motivation for this change

This fixes #51238, where seafile-shared fails to build. As seafile-client needs to be the same version as seafile-shared, that was backported as well

Things done

Only seafile-shared was built and tested so far, as seafile-client is still waiting for the build of Qt to finish on my system.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Robert Schütz added 2 commits November 29, 2018 18:04
@schmittlauch
seafile-shared: 6.2.5 -> 6.2.7
2d3cf40 
(cherry picked from commit 3dccf7d)

reason: built-error of seafile-shared-6.2.4 (see NixOS#51238)
@schmittlauch
seafile-client: 6.2.5 -> 6.2.7
f135007 
(cherry picked from commit 377e0e9)

reason: built-error of seafile-shared-6.2.4 (see NixOS#51238)
@dotlambda dotlambda added the 8.has: port to stable A PR already has a backport to the stable release. label Nov 29, 2018
@dotlambda dotlambda merged commit 7d166c6 into NixOS:release-18.09 Nov 30, 2018
@schmittlauch schmittlauch mentioned this pull request Dec 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schmittlauch @dotlambda @GrahamcOfBorg