Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qbittorrent: 4.1.3 -> 4.1.4 #51242

Merged
merged 1 commit into from Nov 30, 2018
Merged

qbittorrent: 4.1.3 -> 4.1.4 #51242

merged 1 commit into from Nov 30, 2018

Conversation

Anton-Latukha
Copy link
Contributor

Motivation for this change

Just an update.
Changelog: https://www.qbittorrent.org/news.php

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 29, 2018

@GrahamcOfBorg build qbittorrent

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: qbittorrent

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: qbittorrent

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gmw1il5scv5a0mqylsjajwi5psyz6qjq-qbittorrent-4.1.4
shrinking /nix/store/gmw1il5scv5a0mqylsjajwi5psyz6qjq-qbittorrent-4.1.4/bin/qbittorrent
gzipping man pages under /nix/store/gmw1il5scv5a0mqylsjajwi5psyz6qjq-qbittorrent-4.1.4/share/man/
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gmw1il5scv5a0mqylsjajwi5psyz6qjq-qbittorrent-4.1.4/bin
patching script interpreter paths in /nix/store/gmw1il5scv5a0mqylsjajwi5psyz6qjq-qbittorrent-4.1.4
checking for references to /build in /nix/store/gmw1il5scv5a0mqylsjajwi5psyz6qjq-qbittorrent-4.1.4...
postPatchMkspecs
/nix/store/gmw1il5scv5a0mqylsjajwi5psyz6qjq-qbittorrent-4.1.4

@Anton-Latukha
Copy link
Contributor Author

What is the current policy on trying to port to: x86_64-darwin.
I see it was never declared in the package.
Should I try to enable platforms?

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: qbittorrent

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/glpv5ha425layypmcgas036h361q17fw-qbittorrent-4.1.4
shrinking /nix/store/glpv5ha425layypmcgas036h361q17fw-qbittorrent-4.1.4/bin/qbittorrent
gzipping man pages under /nix/store/glpv5ha425layypmcgas036h361q17fw-qbittorrent-4.1.4/share/man/
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/glpv5ha425layypmcgas036h361q17fw-qbittorrent-4.1.4/bin
patching script interpreter paths in /nix/store/glpv5ha425layypmcgas036h361q17fw-qbittorrent-4.1.4
checking for references to /build in /nix/store/glpv5ha425layypmcgas036h361q17fw-qbittorrent-4.1.4...
postPatchMkspecs
/nix/store/glpv5ha425layypmcgas036h361q17fw-qbittorrent-4.1.4

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 29, 2018

"policy" is that it's advised to tweak and test locally before pushing a build to ofBorg's Darwin builder.
Do you have a way to try and build it on macOS on your own?

There should be a way to make it work but it might need some tweaking and some (optionals) Darwin-specific build inputs. It would also require making some configure flags optionals on platform (--enable-systemd)

@Anton-Latukha
Copy link
Contributor Author

Anton-Latukha commented Nov 30, 2018 •
edited

@c0bw3b
Ok.
You are right, I have no macOS equipment, and then I probably should not waste effort and bother ofBorg's Darwin builder.
Thank you for clarification.

worldofpeace
worldofpeace approved these changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and executes just fine locally.

@worldofpeace
Copy link
Contributor

Regarding darwin support, It might be a good idea to open an issue and see if anyone is interested in helping.

@worldofpeace worldofpeace merged commit 2eccd56 into NixOS:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Anton-Latukha @c0bw3b @GrahamcOfBorg @worldofpeace