buildMaven: Support metadata-only dependencies #51240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Not all dependencies mentioned in a
pom.xml
necessarily have JARs or other build artifacts; some may be POMs (metadata) only. In this case,metadata.url
may be set in a dependencies entry (inside theproject-info.json
file created by mvn2nix and consumed by buildMaven) whereurl
is not present.NixOS/mvn2nix-maven-plugin#17 contains an example, with notes on how to reproduce a failure (wherein
mvn2nix-maven-plugin
generates entries with nourl
for artifact-free POMs, andbuildMaven
subsequently fails).Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
"Nothing changed"./result/bin/
) N/Anix path-info -S
before and after) N/A