Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildMaven: Support metadata-only dependencies #51240

Merged
merged 1 commit into from Nov 29, 2018

Conversation

charles-dyfis-net
Copy link
Contributor

Motivation for this change

Not all dependencies mentioned in a pom.xml necessarily have JARs or other build artifacts; some may be POMs (metadata) only. In this case, metadata.url may be set in a dependencies entry (inside the project-info.json file created by mvn2nix and consumed by buildMaven) where url is not present.

NixOS/mvn2nix-maven-plugin#17 contains an example, with notes on how to reproduce a failure (wherein mvn2nix-maven-plugin generates entries with no url for artifact-free POMs, and buildMaven subsequently fails).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) None applicable
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" "Nothing changed"
  • Tested execution of all binary files (usually in ./result/bin/) N/A
  • Determined the impact on package closure size (by running nix path-info -S before and after) N/A
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The circumstances which can make this necessary are discussed in NixOS/mvn2nix-maven-plugin#17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants