Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2c848ea92d96
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a0c7949780b8
Choose a head ref
  • 6 commits
  • 8 files changed
  • 5 contributors

Commits on Nov 28, 2018

  1. elm: extract makeDotElm and fetchElmDeps

    (cherry picked from commit 206a1c0)
    Signed-off-by: Domen Kožar <domen@dev.si>
    jerith666 authored and domenkozar committed Nov 28, 2018

    Partially verified

    This commit is signed with the committer’s verified signature.
    domenkozar’s contribution has been verified via GPG key.
    We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
    Copy the full SHA
    d7e3a07 View commit details
  2. postgresql: enable systemd service notification on 9.6+

    This results in a marginal closure size increase of ~137mb -> ~141mb.
    This only affects the 'out' output, not the 'lib' output, so
    libpq-dependent expressions should not bloat as a result of this.
    
    The type of the systemd service is changed to 'notify' on 9.6+, which
    will help identify when Postgres is starting/shutting down.
    
    Signed-off-by: Austin Seipp <aseipp@pobox.com>
    (cherry picked from commit 1e83cf317443cbc381af72aa09959266bc2d207b)
    Signed-off-by: Domen Kožar <domen@dev.si>
    thoughtpolice authored and domenkozar committed Nov 28, 2018

    Verified

    This commit was signed with the committer’s verified signature.
    domenkozar Domen Kožar
    Copy the full SHA
    4169ce0 View commit details
  3. sage: don't test the downgraded R (#51192)

    Fails transiently. See NixOS/nixpkgs#49249. The
    failures look harmless and are fixed with R 3.5 which will be used in
    sage 8.5.
    
    (cherry picked from commit d6376bc)
    timokau authored Nov 28, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    b7747ce View commit details

Commits on Nov 29, 2018

  1. sd-image: Verifies the FAT partition before copying it.

    This is to ensure `mtools`-based operations don't wreck the FS.
    
    (cherry picked from commit 2e5eb13)
    samueldr committed Nov 29, 2018
    Copy the full SHA
    19f0f47 View commit details
  2. sd-image: Do not use batch operation for mcopy.

    ```
           b      Batch mode. Optimized for huge recursive copies, but less secure if a crash happens during the copy.
    ```
    
    It seems the "less secure if a crash happens" does not need a crash to
    happen.
    
    With batch mode:
    
    ```
    /[...]/.
      Start (0) does not point to parent (___)
    ```
    
    For pretty much everything copied in.
    
    Without batch mode, everything passes `fsck`.
    
    See #51150
    
    (cherry picked from commit 1b6a4d3)
    samueldr committed Nov 29, 2018
    Copy the full SHA
    09c74d9 View commit details
  3. Revert "zfs cannot be distributed. Disabling it in the isos."

    ZFS's popularity is growing, and not including it by default is a
    bit frustrating. On top of that, the base iso includes ZFS
    _anyway_ due to other packages depending upon it.
    
    I think we're in the clear to do this on the basis that Oracle
    probably doesn't care, it is probably fine (the SFLC agrees) and
    we're a small fish. If a copyright holder asks us to, we can
    definitely revert it again.
    
    This reverts commit 33d07c7.
    
    (cherry picked from commit 6db866c)
    grahamc committed Nov 29, 2018

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    grahamc Graham Christensen
    Copy the full SHA
    a0c7949 View commit details
4 changes: 3 additions & 1 deletion nixos/modules/installer/cd-dvd/sd-image.nix
Original file line number Diff line number Diff line change
@@ -134,7 +134,9 @@ in
${config.sdImage.populateBootCommands}
# Copy the populated /boot into the SD image
(cd boot; mcopy -bpsvm -i ../bootpart.img ./* ::)
(cd boot; mcopy -psvm -i ../bootpart.img ./* ::)
# Verify the FAT partition before copying it.
fsck.vfat -vn bootpart.img
dd conv=notrunc if=bootpart.img of=$img seek=$START count=$SECTORS
'';
}) {};
2 changes: 1 addition & 1 deletion nixos/modules/profiles/base.nix
Original file line number Diff line number Diff line change
@@ -46,7 +46,7 @@
];

# Include support for various filesystems.
boot.supportedFilesystems = [ "btrfs" "reiserfs" "vfat" "f2fs" "xfs" "ntfs" "cifs" ];
boot.supportedFilesystems = [ "btrfs" "reiserfs" "vfat" "f2fs" "xfs" "zfs" "ntfs" "cifs" ];

# Configure host id for ZFS to work
networking.hostId = lib.mkDefault "8425e349";
2 changes: 2 additions & 0 deletions nixos/modules/services/databases/postgresql.nix
Original file line number Diff line number Diff line change
@@ -247,6 +247,8 @@ in
# Give Postgres a decent amount of time to clean up after
# receiving systemd's SIGINT.
TimeoutSec = 120;

Type = if versionAtLeast postgresqlPackage.psqlSchema "9.6" then "notify" else "simple";
};

# Wait for PostgreSQL to be ready to accept connections.
1 change: 1 addition & 0 deletions pkgs/applications/science/math/sage/default.nix
Original file line number Diff line number Diff line change
@@ -91,6 +91,7 @@ let
# https://trac.sagemath.org/ticket/25674
R = nixpkgs.R.overrideAttrs (attrs: rec {
name = "R-3.4.4";
doCheck = false;
src = fetchurl {
url = "http://cran.r-project.org/src/base/R-3/${name}.tar.gz";
sha256 = "0dq3jsnwsb5j3fhl0wi3p5ycv8avf8s5j1y4ap3d2mkjmcppvsdk";
40 changes: 6 additions & 34 deletions pkgs/development/compilers/elm/default.nix
Original file line number Diff line number Diff line change
@@ -51,46 +51,17 @@
# that the default of ~/.elm isn't used.

let
makeDotElm = ver: deps:
let versionsDat = ./versions.dat;
cmds = lib.mapAttrsToList (name: info: let
pkg = stdenv.mkDerivation {

name = lib.replaceChars ["/"] ["-"] name + "-${info.version}";

src = fetchurl {
url = "https://github.com/${name}/archive/${info.version}.tar.gz";
meta.homepage = "https://github.com/${name}/";
inherit (info) sha256;
};

phases = [ "unpackPhase" "installPhase" ];

installPhase = ''
mkdir -p $out
cp -r * $out
'';

};
in ''
mkdir -p .elm/${ver}/package/${name}
cp -R ${pkg} .elm/${ver}/package/${name}/${info.version}
'') deps;
in (lib.concatStrings cmds) + ''
mkdir -p .elm/${ver}/package;
cp ${versionsDat} .elm/${ver}/package/versions.dat;
chmod -R +w .elm
'';

fetchElmDeps = import ./fetchElmDeps.nix { inherit stdenv lib fetchurl; };
hsPkgs = haskell.packages.ghc822.override {
overrides = self: super: with haskell.lib;
let elmPkgs = {
elm = overrideCabal (self.callPackage ./packages/elm.nix { }) (drv: {
# sadly with parallelism most of the time breaks compilation
enableParallelBuilding = false;
preConfigure = ''
export ELM_HOME=`pwd`/.elm
'' + (makeDotElm "0.19.0" (import ./packages/elm-elm.nix));
preConfigure = fetchElmDeps {
elmPackages = (import ./packages/elm-elm.nix);
versionsDat = ./versions.dat;
};
buildTools = drv.buildTools or [] ++ [ makeWrapper ];
patches = [
(fetchpatch {
@@ -111,6 +82,7 @@ let
`pacakge/nix/build.sh`
*/
elm-format = self.callPackage ./packages/elm-format.nix {};
inherit fetchElmDeps;
};
in elmPkgs // {
inherit elmPkgs;
11 changes: 11 additions & 0 deletions pkgs/development/compilers/elm/fetchElmDeps.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{stdenv, lib, fetchurl}:

{elmPackages, versionsDat}:

let
makeDotElm = import ./makeDotElm.nix {inherit stdenv lib fetchurl versionsDat;};

in
''
export ELM_HOME=`pwd`/.elm
'' + (makeDotElm "0.19.0" elmPackages)
30 changes: 30 additions & 0 deletions pkgs/development/compilers/elm/makeDotElm.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
{stdenv, lib, fetchurl, versionsDat}:

ver: deps:
let cmds = lib.mapAttrsToList (name: info: let
pkg = stdenv.mkDerivation {
name = lib.replaceChars ["/"] ["-"] name + "-${info.version}";

src = fetchurl {
url = "https://github.com/${name}/archive/${info.version}.tar.gz";
meta.homepage = "https://github.com/${name}/";
inherit (info) sha256;
};

phases = [ "unpackPhase" "installPhase" ];

installPhase = ''
mkdir -p $out
cp -r * $out
'';

};
in ''
mkdir -p .elm/${ver}/package/${name}
cp -R ${pkg} .elm/${ver}/package/${name}/${info.version}
'') deps;
in (lib.concatStrings cmds) + ''
mkdir -p .elm/${ver}/package;
cp ${versionsDat} .elm/${ver}/package/versions.dat;
chmod -R +w .elm
''
8 changes: 6 additions & 2 deletions pkgs/servers/sql/postgresql/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
{ lib, stdenv, glibc, fetchurl, zlib, readline, libossp_uuid, openssl, libxml2, makeWrapper, tzdata }:
{ stdenv, lib, fetchurl, makeWrapper
, glibc, zlib, readline, libossp_uuid, openssl, libxml2, tzdata, systemd
}:

let

@@ -16,7 +18,8 @@ let

buildInputs =
[ zlib readline openssl libxml2 makeWrapper ]
++ lib.optionals (!stdenv.isDarwin) [ libossp_uuid ];
++ lib.optionals (!stdenv.isDarwin) [ libossp_uuid ]
++ lib.optionals (atLeast "9.6" && !stdenv.isDarwin) [ systemd ];

enableParallelBuilding = true;

@@ -33,6 +36,7 @@ let
"--sysconfdir=/etc"
"--libdir=$(lib)/lib"
"--with-system-tzdata=${tzdata}/share/zoneinfo"
(lib.optionalString (atLeast "9.6" && !stdenv.isDarwin) "--with-systemd")
(if stdenv.isDarwin then "--with-uuid=e2fs" else "--with-ossp-uuid")
];