Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gimbal on BDB LR79 #1947

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Fix gimbal on BDB LR79 #1947

merged 1 commit into from
Dec 6, 2018

Conversation

lpgagnon
Copy link
Contributor

Don't delete a non-existent "second" ModuleGimbal, it ends up deleting the first. Also don't delete the non-existent ModuleEnginesFX.

BDB has 2 engines mapped to LR79: juno_engines3d and thorEngine. thorEngine has built-in verniers, so it has 2 ModuleGimbals instead of 1. The RO config strips out the verniers and their gimbal setting. The RO config for juno_engines3d tries to strip out the same verniers, but there aren't any. I don't speak ModuleManager, but it would seem !MODULE[ModuleGimbal],1 is intended to match "the second one", but that "second of one item" is that one item.

Don't delete a non-existent "second" ModuleGimbal, it ends up deleting the first. Also don't delete the non-existent ModuleEnginesFX.

BDB has 2 engines mapped to LR79: juno_engines3d and thorEngine. thorEngine has built-in verniers, so it has 2 ModuleGimbals instead of 1. The RO config strips out the verniers and their gimbal setting. The RO config for juno_engines3d tries to strip out the same verniers, but there aren't any. I don't speak ModuleManager, but it would seem `!MODULE[ModuleGimbal],1` is intended to match "the second one", but that "second of one item" is that one item.
@pap1723
Copy link
Contributor

pap1723 commented Dec 6, 2018

I have noticed this issue as well with the LR79 from BDB. It causes some difficult ascents.

@pap1723 pap1723 merged commit 59adc4d into KSP-RO:master Dec 6, 2018
@lpgagnon lpgagnon deleted the patch-1 branch August 1, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants