Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libapparmor: drop patch, fix build w/musl #51261

Merged
merged 1 commit into from Dec 1, 2018
Merged

libapparmor: drop patch, fix build w/musl #51261

merged 1 commit into from Dec 1, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Nov 30, 2018

Motivation for this change

Fixes build at least-- didn't confirm details.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

And I can build something with it-- although don't remember what!

Just found a screen session with this branch and a build test :).

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libapparmor

Partial log (click to expand)

/nix/store/vs0hccv2ad1lcrrhr66n7cxh7nz5pqv1-libapparmor-2.13.1

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: libapparmor

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libapparmor

Partial log (click to expand)

/nix/store/lg81jd5257znzf3jiaaaxqs9jwh2za3w-libapparmor-2.13.1

@c0bw3b c0bw3b merged commit c4852e3 into NixOS:master Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @c0bw3b