Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cockroachdb: 2.0.0 -> 2.1.1 #51247

Merged
merged 1 commit into from Nov 29, 2018
Merged

cockroachdb: 2.0.0 -> 2.1.1 #51247

merged 1 commit into from Nov 29, 2018

Conversation

thoughtpolice
Copy link
Member

@thoughtpolice thoughtpolice commented Nov 29, 2018 •
edited

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thoughtpolice thoughtpolice self-assigned this Nov 29, 2018
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: cockroachdb

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cockroachdb

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/1224r89lmcbjk85wfwam39zmais4ihil-cockroach-2.1.1-bin/bin
patching script interpreter paths in /nix/store/1224r89lmcbjk85wfwam39zmais4ihil-cockroach-2.1.1-bin
checking for references to /build in /nix/store/1224r89lmcbjk85wfwam39zmais4ihil-cockroach-2.1.1-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/c4ffsfhkk1nf923ygvqksr7y3j2xrjk7-cockroach-2.1.1-man
gzipping man pages under /nix/store/c4ffsfhkk1nf923ygvqksr7y3j2xrjk7-cockroach-2.1.1-man/share/man/
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/c4ffsfhkk1nf923ygvqksr7y3j2xrjk7-cockroach-2.1.1-man
checking for references to /build in /nix/store/c4ffsfhkk1nf923ygvqksr7y3j2xrjk7-cockroach-2.1.1-man...
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
/nix/store/1224r89lmcbjk85wfwam39zmais4ihil-cockroach-2.1.1-bin

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: cockroachdb

Partial log (click to expand)

github.com/cockroachdb/cockroach/vendor/github.com/spf13/cobra/doc
github.com/cockroachdb/cockroach/pkg/ui/distoss
github.com/cockroachdb/cockroach/pkg/sqlmigrations
github.com/cockroachdb/cockroach/pkg/sql/pgwire
github.com/cockroachdb/cockroach/pkg/server
make[1]: *** [Makefile:760: cockroachoss] Error 2
make[1]: Leaving directory '/private/tmp/nix-build-cockroach-2.1.1.drv-0/go/src/github.com/cockroachdb/cockroach/src/github.com/cockroachdb/cockroach'
make: *** [Makefile:6: buildoss] Error 2
builder for '/nix/store/imv91daf9zni4a53kl84snxjvff2sxln-cockroach-2.1.1.drv' failed with exit code 2
error: build of '/nix/store/imv91daf9zni4a53kl84snxjvff2sxln-cockroach-2.1.1.drv' failed

@thoughtpolice
Copy link
Member Author

@GrahamcOfBorg build cockroachdb

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: cockroachdb

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cockroachdb

Partial log (click to expand)

/nix/store/1224r89lmcbjk85wfwam39zmais4ihil-cockroach-2.1.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: cockroachdb

Partial log (click to expand)

find: '/nix/store/xwqwdwwf39746qfb05m7aascz6n00iiw-cockroach-2.1.1': No such file or directory
find: '/nix/store/xwqwdwwf39746qfb05m7aascz6n00iiw-cockroach-2.1.1': No such file or directory
find: '/nix/store/xwqwdwwf39746qfb05m7aascz6n00iiw-cockroach-2.1.1': No such file or directory
find: '/nix/store/xwqwdwwf39746qfb05m7aascz6n00iiw-cockroach-2.1.1': No such file or directory
find: '/nix/store/xwqwdwwf39746qfb05m7aascz6n00iiw-cockroach-2.1.1': No such file or directory
find: '/nix/store/xwqwdwwf39746qfb05m7aascz6n00iiw-cockroach-2.1.1': No such file or directory
find: '/nix/store/xwqwdwwf39746qfb05m7aascz6n00iiw-cockroach-2.1.1': No such file or directory
find: '/nix/store/xwqwdwwf39746qfb05m7aascz6n00iiw-cockroach-2.1.1': No such file or directory
find: '/nix/store/xwqwdwwf39746qfb05m7aascz6n00iiw-cockroach-2.1.1': No such file or directory
/nix/store/x3fi7q6fp44fmdiby88rpjjw2bmms13b-cockroach-2.1.1-bin

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: cockroachdb

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@thoughtpolice
Copy link
Member Author

@GrahamcOfBorg build cockroachdb

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cockroachdb

Partial log (click to expand)

/nix/store/1224r89lmcbjk85wfwam39zmais4ihil-cockroach-2.1.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: cockroachdb

Partial log (click to expand)

/nix/store/x3fi7q6fp44fmdiby88rpjjw2bmms13b-cockroach-2.1.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: cockroachdb

Partial log (click to expand)

find: '/nix/store/xwqwdwwf39746qfb05m7aascz6n00iiw-cockroach-2.1.1': No such file or directory
find: '/nix/store/xwqwdwwf39746qfb05m7aascz6n00iiw-cockroach-2.1.1': No such file or directory
find: '/nix/store/xwqwdwwf39746qfb05m7aascz6n00iiw-cockroach-2.1.1': No such file or directory
find: '/nix/store/xwqwdwwf39746qfb05m7aascz6n00iiw-cockroach-2.1.1': No such file or directory
find: '/nix/store/xwqwdwwf39746qfb05m7aascz6n00iiw-cockroach-2.1.1': No such file or directory
find: '/nix/store/xwqwdwwf39746qfb05m7aascz6n00iiw-cockroach-2.1.1': No such file or directory
find: '/nix/store/xwqwdwwf39746qfb05m7aascz6n00iiw-cockroach-2.1.1': No such file or directory
find: '/nix/store/xwqwdwwf39746qfb05m7aascz6n00iiw-cockroach-2.1.1': No such file or directory
find: '/nix/store/xwqwdwwf39746qfb05m7aascz6n00iiw-cockroach-2.1.1': No such file or directory
/nix/store/x3fi7q6fp44fmdiby88rpjjw2bmms13b-cockroach-2.1.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cockroachdb

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/1224r89lmcbjk85wfwam39zmais4ihil-cockroach-2.1.1-bin/bin
patching script interpreter paths in /nix/store/1224r89lmcbjk85wfwam39zmais4ihil-cockroach-2.1.1-bin
checking for references to /build in /nix/store/1224r89lmcbjk85wfwam39zmais4ihil-cockroach-2.1.1-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/c4ffsfhkk1nf923ygvqksr7y3j2xrjk7-cockroach-2.1.1-man
gzipping man pages under /nix/store/c4ffsfhkk1nf923ygvqksr7y3j2xrjk7-cockroach-2.1.1-man/share/man/
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/c4ffsfhkk1nf923ygvqksr7y3j2xrjk7-cockroach-2.1.1-man
checking for references to /build in /nix/store/c4ffsfhkk1nf923ygvqksr7y3j2xrjk7-cockroach-2.1.1-man...
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
/nix/store/1224r89lmcbjk85wfwam39zmais4ihil-cockroach-2.1.1-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cockroachdb

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/8ica1wsag47g9qk0zh3vn9zdj6py6spm-cockroach-2.1.1-bin/bin
patching script interpreter paths in /nix/store/8ica1wsag47g9qk0zh3vn9zdj6py6spm-cockroach-2.1.1-bin
checking for references to /build in /nix/store/8ica1wsag47g9qk0zh3vn9zdj6py6spm-cockroach-2.1.1-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/lvmz0xjizpj6niknwfxzajwa7w9j068n-cockroach-2.1.1-man
gzipping man pages under /nix/store/lvmz0xjizpj6niknwfxzajwa7w9j068n-cockroach-2.1.1-man/share/man/
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/lvmz0xjizpj6niknwfxzajwa7w9j068n-cockroach-2.1.1-man
checking for references to /build in /nix/store/lvmz0xjizpj6niknwfxzajwa7w9j068n-cockroach-2.1.1-man...
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
/nix/store/8ica1wsag47g9qk0zh3vn9zdj6py6spm-cockroach-2.1.1-bin

@thoughtpolice
cockroachdb: 2.0.0 -> 2.1.1, aarch64 support
9c7e73f 
This also splits the .bin output to have a separate .man attribute:
previously it contained both.

This also adds provisional support for aarch64-linux, which seems to
build easily. (Full testing will ideally come via NixOS tests later)

Signed-off-by: Austin Seipp <aseipp@pobox.com>
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: cockroachdb

Partial log (click to expand)

/nix/store/x3fi7q6fp44fmdiby88rpjjw2bmms13b-cockroach-2.1.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cockroachdb

Partial log (click to expand)

/nix/store/1224r89lmcbjk85wfwam39zmais4ihil-cockroach-2.1.1-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cockroachdb

Partial log (click to expand)

/nix/store/8ica1wsag47g9qk0zh3vn9zdj6py6spm-cockroach-2.1.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: cockroachdb

Partial log (click to expand)

/nix/store/x3fi7q6fp44fmdiby88rpjjw2bmms13b-cockroach-2.1.1-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cockroachdb

Partial log (click to expand)

/nix/store/8ica1wsag47g9qk0zh3vn9zdj6py6spm-cockroach-2.1.1-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cockroachdb

Partial log (click to expand)

/nix/store/1224r89lmcbjk85wfwam39zmais4ihil-cockroach-2.1.1-bin

@thoughtpolice thoughtpolice merged commit c90a45a into NixOS:master Nov 29, 2018
@thoughtpolice thoughtpolice deleted the cockroachdb-2.1 branch November 29, 2018 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rushmorem rushmorem Awaiting requested review from rushmorem

Assignees

@thoughtpolice thoughtpolice

Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thoughtpolice @GrahamcOfBorg