Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.datrie: fix build #51250

Merged
merged 1 commit into from Nov 30, 2018
Merged

python3Packages.datrie: fix build #51250

merged 1 commit into from Nov 30, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Nov 29, 2018

Motivation for this change

python3Packages.datrie is broken: https://hydra.nixos.org/build/84807067
Need to fix it for snakemake to build for #50900

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl requested a review from FRidh as a code owner November 29, 2018 21:18
@veprbl
Copy link
Member Author

veprbl commented Nov 29, 2018

@GrahamcOfBorg build python3Packages.datrie

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3Packages.datrie

Partial log (click to expand)

    import datrie

tests/test_random.py::test_contains
  /nix/store/23fn8z4l5hqp0ja7ck3hsqndlsd6i9c2-python3.7-hypothesis-3.79.3/lib/python3.7/site-packages/hypothesis/internal/validation.py:151: HypothesisDeprecationWarning: You should remove the average_size argument, because it is deprecated and no longer has any effect.  Please open an issue if the default distribution of examples does not work for you.
    'You should remove the average_size argument, because it is '

-- Docs: https://docs.pytest.org/en/latest/warnings.html
==================== 38 passed, 2 warnings in 3.24 seconds =====================
pytestcachePhase
/nix/store/fypjd4wnfklpwisxb1h40rpii9mj9ya1-python3.7-datrie-0.7.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3Packages.datrie

Partial log (click to expand)

    import datrie

tests/test_random.py::test_contains
  /nix/store/lpfwfnhd3h73c6mga4f2mrafsnxj1g7z-python3.7-hypothesis-3.79.3/lib/python3.7/site-packages/hypothesis/internal/validation.py:151: HypothesisDeprecationWarning: You should remove the average_size argument, because it is deprecated and no longer has any effect.  Please open an issue if the default distribution of examples does not work for you.
    'You should remove the average_size argument, because it is '

-- Docs: https://docs.pytest.org/en/latest/warnings.html
==================== 38 passed, 2 warnings in 6.04 seconds =====================
pytestcachePhase
/nix/store/5lmlw8qams6707rq9mh330f4gi48qmfx-python3.7-datrie-0.7.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3Packages.datrie

Partial log (click to expand)

    import datrie

tests/test_random.py::test_contains
  /nix/store/qcvmhqrdd8x8km912zhy4nw6ks4wjycs-python3.7-hypothesis-3.79.3/lib/python3.7/site-packages/hypothesis/internal/validation.py:151: HypothesisDeprecationWarning: You should remove the average_size argument, because it is deprecated and no longer has any effect.  Please open an issue if the default distribution of examples does not work for you.
    'You should remove the average_size argument, because it is '

-- Docs: https://docs.pytest.org/en/latest/warnings.html
==================== 38 passed, 2 warnings in 1.36 seconds =====================
pytestcachePhase
/nix/store/k7yv5azc4gxq4gbka7qa1ymvkhjwfgg4-python3.7-datrie-0.7.1

timokau
timokau requested changes Nov 29, 2018
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this :)

Please add a link to pytries/datrie#52 as a comment. It would be nicer to use the update_c.sh script recommended there instead of hardcoding the filenames.

@veprbl
Copy link
Member Author

veprbl commented Nov 30, 2018

@timokau Thank you!

@GrahamcOfBorg build python2Packages.datrie python36Packages.datrie python37Packages.datrie

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python2Packages.datrie, python36Packages.datrie, python37Packages.datrie

Partial log (click to expand)

tests/test_random.py::test_contains
  /nix/store/hgsxghb3q8dk72ycfhvjq5y8w3pzznfm-python3.6-hypothesis-3.79.3/lib/python3.6/site-packages/hypothesis/internal/validation.py:151: HypothesisDeprecationWarning: You should remove the average_size argument, because it is deprecated and no longer has any effect.  Please open an issue if the default distribution of examples does not work for you.
    'You should remove the average_size argument, because it is '

-- Docs: https://docs.pytest.org/en/latest/warnings.html
==================== 38 passed, 1 warnings in 1.63 seconds =====================
pytestcachePhase
/nix/store/pi04sl5frv3xz3lhfnzx42ps1z79wl8m-python2.7-datrie-0.7.1
/nix/store/5qrpsypm8k9d0s76svphyzwch2g1pa59-python3.6-datrie-0.7.1
/nix/store/4jwq028bv9535337gwr5pi22zdhdwraj-python3.7-datrie-0.7.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2Packages.datrie, python36Packages.datrie, python37Packages.datrie

Partial log (click to expand)

tests/test_random.py::test_contains
  /nix/store/dj1lc4wk3y95x4vkg3c22yrkfsz17k4m-python3.6-hypothesis-3.79.3/lib/python3.6/site-packages/hypothesis/internal/validation.py:151: HypothesisDeprecationWarning: You should remove the average_size argument, because it is deprecated and no longer has any effect.  Please open an issue if the default distribution of examples does not work for you.
    'You should remove the average_size argument, because it is '

-- Docs: https://docs.pytest.org/en/latest/warnings.html
==================== 38 passed, 1 warnings in 1.82 seconds =====================
pytestcachePhase
/nix/store/mdf9l1n0kffvaws1ddhda3sfih1w7dip-python2.7-datrie-0.7.1
/nix/store/6ikj72pgvcf9bvpa5hgmv4y45dkps3rg-python3.6-datrie-0.7.1
/nix/store/sjxmnxsi4ziqdi5d7d7c4wsnjqn6sais-python3.7-datrie-0.7.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2Packages.datrie, python36Packages.datrie, python37Packages.datrie

Partial log (click to expand)

tests/test_random.py::test_contains
  /nix/store/swssc4mzrh1an2y7n7c768ps00f42r19-python3.6-hypothesis-3.79.3/lib/python3.6/site-packages/hypothesis/internal/validation.py:151: HypothesisDeprecationWarning: You should remove the average_size argument, because it is deprecated and no longer has any effect.  Please open an issue if the default distribution of examples does not work for you.
    'You should remove the average_size argument, because it is '

-- Docs: https://docs.pytest.org/en/latest/warnings.html
==================== 38 passed, 1 warnings in 3.35 seconds =====================
pytestcachePhase
/nix/store/3scb978wx6qynppxfh0zqagl3abjak6r-python2.7-datrie-0.7.1
/nix/store/07zm533sd3a45apnfsv75c9vj4m9b85a-python3.6-datrie-0.7.1
/nix/store/sha323kxbbm693yg6b8gksi6rl34zsmc-python3.7-datrie-0.7.1

@timokau timokau merged commit cf1fb28 into NixOS:master Nov 30, 2018
@veprbl veprbl deleted the pr/datrie_fix branch December 1, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @GrahamcOfBorg @timokau