Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] ungoogled-chromium: init at 70.0.3538.110-1 #51266

Closed
wants to merge 1 commit into from
Closed

[WIP] ungoogled-chromium: init at 70.0.3538.110-1 #51266

wants to merge 1 commit into from

Conversation

rht
Copy link
Member

@rht rht commented Nov 30, 2018

Motivation for this change

This supersedes #30916, #51195 to provide chromium sans Google integration.

  • Try another binary. The official binary always segfaults on my machine.
  • Reuse the package inputs & buildInputs from google-chrome (I am still figuring out how to do this :/). Also do this for brave.
  • Download the .desktop file from AUR.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rht rht mentioned this pull request Nov 30, 2018
Closed
10 tasks
bendlas
bendlas reviewed Dec 9, 2018
View reviewed changes
pkgs/applications/networking/browsers/ungoogled-chromium-bin/default.nix
pkgrel = "1";

src = fetchurl {
url = "https://cloud.woelkli.com/s/${_url_id}/download";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we downloading Arch's prebuilt binary here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this trusts an url, not even on a well-known arch-linux domain, maybe this should go to https://github.com/nix-community/NUR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I found it from the PKGBUILD in the AUR repo.
OK, I think so as well. I found some other packages that have been committed do have references to AUR packages. Perhaps they should be moved to NUR.

@bendlas
Copy link
Contributor

bendlas commented Dec 9, 2018

It seems to me, that this package should rather be named chromiumUngoogledBin, since it downloads and installs a pre-built version of ungoogled-chromium.

@bendlas
Copy link
Contributor

bendlas commented Dec 9, 2018 •
edited

@rht I like your approach in #51195 a lot and if you want, we can continue work on that one.

@mmahut
Copy link
Member

mmahut commented Aug 13, 2019

Are there any updates on this pull request, please?

@rht
Copy link
Member Author

rht commented Aug 13, 2019

@mmahut the problem with the approach in this PR is the chromium binary being downloaded from a third party source, which prevents it from being the approach suitable to be included in core Nix packages. This binary approach could be placed in NUR, however.

@doronbehar
Copy link
Contributor

The ungoogled-chromium is available in Nixpkgs. Thanks to @squalus. I'm closing this.

@doronbehar doronbehar closed this May 16, 2020
@rht rht deleted the ungoogled-chromium-bin branch May 16, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendlas bendlas bendlas left review comments

Assignees
No one assigned
Labels
2.status: work-in-progress 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rht @bendlas @mmahut @doronbehar @infinisil @GrahamcOfBorg