MEB-100: Add a new datasets page #313
Conversation
|
Can one of the admins verify this patch? |
|
@mayhem @paramsingh Any thoughts/suggestions/issues? |
|
@brainzbot add to whitelist |
|
Do you mind posting a screenshot for an easier review? |
|
@paramsingh A screenshot of the output? |
|
A screenshot of the page in the browser |
|
@paramsingh I was having trouble setting up the whole repo locally (because Docker was failing), so I skipped that part. So I simply tested it using a codepen pen with only the actual html/css files. The entire look doesn't have the MB styles, but you can see the changed texts and the 2 column layout, as well as the smaller logos and text flowing around the logo. So I believe the intended changes have been applied? |
There was a problem hiding this comment.
This looks really good! =)
There are a few changes that I'd like made though.
We should make the dataset descriptions more concise in my opinion, now that we have a two column layout. Just the one paragraph with a link to the projects main site, a small description of the dataset and link to the dumps would be great!.
| {% block content %} | ||
| <h1 class="page-title">{{ _('The MetaBrainz Datasets') }}</h1> | ||
|
|
||
| <p> We ask <a href="{{ url_for('users.account_type') }}">commercial users</a> to <a href="{{ url_for('users.account_type') }}">support us</a> in order to help fund the creation and maintenance of these datasets. </p> |
There was a problem hiding this comment.
This should be part of the next paragraph that starts The MetaBrainz Foundataion provides free, open access...
| <p> We ask <a href="{{ url_for('users.account_type') }}">commercial users</a> to <a href="{{ url_for('users.account_type') }}">support us</a> in order to help fund the creation and maintenance of these datasets. </p> | ||
|
|
||
| <p> | ||
| The MetaBrainz Foundation provides free, open access to various types of useful data gathered and verified by volunteers. Here, we list and describe the various datasets we maintain. |
There was a problem hiding this comment.
I would prefer it if all the text in the html is not in one line, makes it easier to read in text editors and in the github review interface.
There was a problem hiding this comment.
This goes for all descriptions. We generally try to keep lines around a 100-120 columns long.
|
@paramsingh Anything else? |
The following changes have been made: