nixos/gitea: fix mysql issue, add mysql socket auth, and add a nixos test #49814

aanderse · 2018-11-06T02:14:56Z

Motivation for this change

My gitea instance has been crashing every few nights because the systemd service is assuming a postgresql database.

Things done

fixed the issue causing my gitea instance to crash on start sometimes because it is using a mysql database
added mysql socket authentication
added a nixos test for gitea

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

ping @disassembler @etu

GrahamcOfBorg · 2018-11-06T02:27:51Z

Success on x86_64-linux (full log)

Attempted: gitea

Partial log (click to expand)

these paths will be fetched (14.81 MiB download, 63.53 MiB unpacked):
  /nix/store/7c7g2h30snvmw4a2wjspjgwal469x0k5-gitea-1.5.2-bin
  /nix/store/jcjcgvqznzm5lclckwswp1557fd64cna-gitea-1.5.2-data
copying path '/nix/store/jcjcgvqznzm5lclckwswp1557fd64cna-gitea-1.5.2-data' from 'https://cache.nixos.org'...
copying path '/nix/store/7c7g2h30snvmw4a2wjspjgwal469x0k5-gitea-1.5.2-bin' from 'https://cache.nixos.org'...
/nix/store/7c7g2h30snvmw4a2wjspjgwal469x0k5-gitea-1.5.2-bin

GrahamcOfBorg · 2018-11-06T02:37:45Z

Failure on aarch64-linux (full log)

Attempted: gitea

Partial log (click to expand)

code.gitea.io/gitea/routers/api/v1/repo
code.gitea.io/gitea/routers
code.gitea.io/gitea/routers/api/v1/user
code.gitea.io/gitea/routers/api/v1/admin
code.gitea.io/gitea/routers/api/v1/org
code.gitea.io/gitea/routers/admin
code.gitea.io/gitea/routers/api/v1
code.gitea.io/gitea/routers/routes
builder for '/nix/store/64ay7qkdrv53b2bsrz2n0bfq22x0a3zp-gitea-1.5.2.drv' failed with exit code 46
error: build of '/nix/store/64ay7qkdrv53b2bsrz2n0bfq22x0a3zp-gitea-1.5.2.drv' failed

aanderse · 2018-11-06T03:16:01Z

Note failure on aarch64-linux isn't unexpected... #45968

Anyone know why that isn't unexpected? Can we fix it?

@GrahamcOfBorg test gitea

etu · 2018-11-06T06:30:34Z

@aanderse I was thinking, not related to the aarch64-failure. But maybe we should have a test machine in the same test file for postgres as well? Just to make sure that both works?

GrahamcOfBorg · 2018-11-07T02:00:50Z

Success on x86_64-linux (full log)

Attempted: gitea

Partial log (click to expand)

/nix/store/7c7g2h30snvmw4a2wjspjgwal469x0k5-gitea-1.5.2-bin

GrahamcOfBorg · 2018-11-07T02:06:46Z

Failure on aarch64-linux (full log)

Attempted: gitea

Partial log (click to expand)

        /nix/store/2jz7z8f6xnx1cv8vr6fmf21y96fg86ri-go-1.11/share/go/src/cmd/compile/internal/gc/pgen.go:223 +0x70
cmd/compile/internal/gc.funccompile(0x4000678160)
        /nix/store/2jz7z8f6xnx1cv8vr6fmf21y96fg86ri-go-1.11/share/go/src/cmd/compile/internal/gc/pgen.go:209 +0xbc
cmd/compile/internal/gc.Main(0x7b9238)
        /nix/store/2jz7z8f6xnx1cv8vr6fmf21y96fg86ri-go-1.11/share/go/src/cmd/compile/internal/gc/main.go:637 +0x2664
main.main()
        /nix/store/2jz7z8f6xnx1cv8vr6fmf21y96fg86ri-go-1.11/share/go/src/cmd/compile/main.go:51 +0x8c
code.gitea.io/gitea/vendor/github.com/RoaringBitmap/roaring
builder for '/nix/store/64ay7qkdrv53b2bsrz2n0bfq22x0a3zp-gitea-1.5.2.drv' failed with exit code 43
error: build of '/nix/store/64ay7qkdrv53b2bsrz2n0bfq22x0a3zp-gitea-1.5.2.drv' failed

GrahamcOfBorg · 2018-11-07T08:03:24Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.gitea

Partial log (click to expand)

Cannot nix-instantiate `tests.gitea' because:
error: attribute 'gitea' in selection path 'tests.gitea' not found

GrahamcOfBorg · 2018-11-07T08:09:35Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: tests.gitea

Partial log (click to expand)

Cannot nix-instantiate `tests.gitea' because:
error: attribute 'gitea' in selection path 'tests.gitea' not found

aanderse · 2018-11-07T11:15:25Z

Still working on postgres test as it errors out in the pre-start script. More to come.

aanderse · 2018-11-08T02:03:42Z

@GrahamcOfBorg test postgresql

Something funny going on with my machine...

GrahamcOfBorg · 2018-11-08T02:03:56Z

Success on aarch64-linux

Attempted: tests.postgresql

No partial log is available.

GrahamcOfBorg · 2018-11-08T02:04:40Z

Success on x86_64-linux

Attempted: tests.postgresql

No partial log is available.

GrahamcOfBorg · 2018-11-08T02:23:31Z

Success on x86_64-linux (full log)

Attempted: gitea

Partial log (click to expand)

/nix/store/7c7g2h30snvmw4a2wjspjgwal469x0k5-gitea-1.5.2-bin

aanderse · 2018-11-08T02:24:06Z

@GrahamcOfBorg test gitea

GrahamcOfBorg · 2018-11-08T02:24:14Z

Success on x86_64-linux

Attempted: tests.gitea

No partial log is available.

GrahamcOfBorg · 2018-11-08T02:24:21Z

Success on aarch64-linux

Attempted: tests.gitea

No partial log is available.

GrahamcOfBorg · 2018-11-08T02:33:41Z

Failure on aarch64-linux (full log)

Attempted: gitea

Partial log (click to expand)

code.gitea.io/gitea/vendor/github.com/go-macaron/cache/memcache
code.gitea.io/gitea/vendor/gopkg.in/testfixtures.v2
code.gitea.io/gitea/modules/cache
code.gitea.io/gitea/modules/highlight
code.gitea.io/gitea/modules/base
code.gitea.io/gitea/modules/options
code.gitea.io/gitea/modules/markup
code.gitea.io/gitea/modules/markup/markdown
builder for '/nix/store/64ay7qkdrv53b2bsrz2n0bfq22x0a3zp-gitea-1.5.2.drv' failed with exit code 47
error: build of '/nix/store/64ay7qkdrv53b2bsrz2n0bfq22x0a3zp-gitea-1.5.2.drv' failed

aanderse · 2018-11-08T03:32:38Z

@etu if you're happy with this I'll look for someone to merge.

nixos/modules/services/misc/gitea.nix

GrahamcOfBorg · 2018-11-08T11:35:02Z

Success on x86_64-linux (full log)

Attempted: gitea

Partial log (click to expand)

these paths will be fetched (19.92 MiB download, 99.66 MiB unpacked):
  /nix/store/7c7g2h30snvmw4a2wjspjgwal469x0k5-gitea-1.5.2-bin
  /nix/store/jcjcgvqznzm5lclckwswp1557fd64cna-gitea-1.5.2-data
  /nix/store/zma4ryc9awzsqgslnwxfczgl2b5xmc4v-git-2.19.1
copying path '/nix/store/jcjcgvqznzm5lclckwswp1557fd64cna-gitea-1.5.2-data' from 'https://cache.nixos.org'...
copying path '/nix/store/zma4ryc9awzsqgslnwxfczgl2b5xmc4v-git-2.19.1' from 'https://cache.nixos.org'...
copying path '/nix/store/7c7g2h30snvmw4a2wjspjgwal469x0k5-gitea-1.5.2-bin' from 'https://cache.nixos.org'...
/nix/store/7c7g2h30snvmw4a2wjspjgwal469x0k5-gitea-1.5.2-bin

GrahamcOfBorg · 2018-11-08T11:43:11Z

Failure on aarch64-linux (full log)

Attempted: gitea

Partial log (click to expand)

code.gitea.io/gitea/vendor/github.com/stretchr/testify/assert
code.gitea.io/gitea/vendor/gopkg.in/macaron.v1
code.gitea.io/gitea/vendor/github.com/keybase/go-crypto/openpgp
code.gitea.io/gitea/vendor/github.com/RoaringBitmap/roaring
code.gitea.io/gitea/modules/setting
code.gitea.io/gitea/modules/base
code.gitea.io/gitea/modules/mailer
code.gitea.io/gitea/modules/auth/oauth2
builder for '/nix/store/64ay7qkdrv53b2bsrz2n0bfq22x0a3zp-gitea-1.5.2.drv' failed with exit code 49
error: build of '/nix/store/64ay7qkdrv53b2bsrz2n0bfq22x0a3zp-gitea-1.5.2.drv' failed

…hoice

…n succeeds so the application can start

GrahamcOfBorg added 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Nov 6, 2018

aanderse force-pushed the gitea branch from 86011f0 to 173b6d1 Compare November 7, 2018 01:44

aanderse force-pushed the gitea branch from 173b6d1 to 66f4041 Compare November 8, 2018 02:09

etu reviewed Nov 8, 2018

View reviewed changes

nixos/modules/services/misc/gitea.nix Outdated Show resolved Hide resolved

aanderse force-pushed the gitea branch from 66f4041 to 739c239 Compare November 8, 2018 11:20

aanderse added 2 commits November 8, 2018 17:30

nixos/gitea: fix systemd after target when mysql is the database of c…

0bbb6f4

…hoice

nixos/gitea: add mysql socket authentication as an option

3ed52c7

nixos/gitea: add a nixos test to ensure the initial database migratio…

0dde47a

…n succeeds so the application can start

aanderse force-pushed the gitea branch from 739c239 to 0dde47a Compare November 8, 2018 22:31

aanderse changed the title ~~gitea: fix mysql issue, add mysql socket auth, and add a nixos test~~ nixos/gitea: fix mysql issue, add mysql socket auth, and add a nixos test Nov 8, 2018

c0bw3b merged commit 6399b10 into NixOS:master Nov 8, 2018

c0bw3b mentioned this pull request Nov 8, 2018

[18.09] nixos/gitea: fix mysql issue, add mysql socket auth, and add a nixos test #49954

Merged

9 tasks

aanderse deleted the gitea branch November 9, 2018 01:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nixos/gitea: fix mysql issue, add mysql socket auth, and add a nixos test #49814

nixos/gitea: fix mysql issue, add mysql socket auth, and add a nixos test #49814

aanderse commented Nov 6, 2018 •

edited

GrahamcOfBorg commented Nov 6, 2018

GrahamcOfBorg commented Nov 6, 2018

aanderse commented Nov 6, 2018

etu commented Nov 6, 2018

GrahamcOfBorg commented Nov 7, 2018

GrahamcOfBorg commented Nov 7, 2018

GrahamcOfBorg commented Nov 7, 2018

GrahamcOfBorg commented Nov 7, 2018

aanderse commented Nov 7, 2018

aanderse commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

aanderse commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

aanderse commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

nixos/gitea: fix mysql issue, add mysql socket auth, and add a nixos test #49814

nixos/gitea: fix mysql issue, add mysql socket auth, and add a nixos test #49814

Conversation

aanderse commented Nov 6, 2018 • edited

Motivation for this change

Things done

GrahamcOfBorg commented Nov 6, 2018

GrahamcOfBorg commented Nov 6, 2018

aanderse commented Nov 6, 2018

etu commented Nov 6, 2018

GrahamcOfBorg commented Nov 7, 2018

GrahamcOfBorg commented Nov 7, 2018

GrahamcOfBorg commented Nov 7, 2018

GrahamcOfBorg commented Nov 7, 2018

aanderse commented Nov 7, 2018

aanderse commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

aanderse commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

aanderse commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

GrahamcOfBorg commented Nov 8, 2018

aanderse commented Nov 6, 2018 •

edited