Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gimp: get rid of compiler from the runtime closure #49812

Merged
merged 1 commit into from Nov 7, 2018
Merged

gimp: get rid of compiler from the runtime closure #49812

merged 1 commit into from Nov 7, 2018

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Nov 6, 2018

Motivation for this change

Not needed at runtime, reference only retained via $ gimp --version --verbose output.

/cc @jtojnar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gimp

Partial log (click to expand)

wrapping `/nix/store/3ins7rj32cravqb55yqmnq2bjsmfk2g5-gimp-2.10.6/lib/gimp/2.0/plug-ins/palette-to-gradient/palette-to-gradient.py'...
wrapping `/nix/store/3ins7rj32cravqb55yqmnq2bjsmfk2g5-gimp-2.10.6/lib/gimp/2.0/plug-ins/palette-sort/palette-sort.py'...
wrapping `/nix/store/3ins7rj32cravqb55yqmnq2bjsmfk2g5-gimp-2.10.6/lib/gimp/2.0/plug-ins/palette-offset/palette-offset.py'...
wrapping `/nix/store/3ins7rj32cravqb55yqmnq2bjsmfk2g5-gimp-2.10.6/lib/gimp/2.0/plug-ins/histogram-export/histogram-export.py'...
wrapping `/nix/store/3ins7rj32cravqb55yqmnq2bjsmfk2g5-gimp-2.10.6/lib/gimp/2.0/plug-ins/gradients-save-as-css/gradients-save-as-css.py'...
wrapping `/nix/store/3ins7rj32cravqb55yqmnq2bjsmfk2g5-gimp-2.10.6/lib/gimp/2.0/plug-ins/foggify/foggify.py'...
wrapping `/nix/store/3ins7rj32cravqb55yqmnq2bjsmfk2g5-gimp-2.10.6/lib/gimp/2.0/plug-ins/file-openraster/file-openraster.py'...
wrapping `/nix/store/3ins7rj32cravqb55yqmnq2bjsmfk2g5-gimp-2.10.6/lib/gimp/2.0/plug-ins/colorxhtml/colorxhtml.py'...
wrapping `/nix/store/3ins7rj32cravqb55yqmnq2bjsmfk2g5-gimp-2.10.6/lib/gimp/2.0/plug-ins/python-console/python-console.py'...
/nix/store/3ins7rj32cravqb55yqmnq2bjsmfk2g5-gimp-2.10.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gimp

Partial log (click to expand)

wrapping `/nix/store/5ypz5l6m1qbh89kpsqjr6h5c3cv43fj3-gimp-2.10.6/lib/gimp/2.0/plug-ins/palette-sort/palette-sort.py'...
wrapping `/nix/store/5ypz5l6m1qbh89kpsqjr6h5c3cv43fj3-gimp-2.10.6/lib/gimp/2.0/plug-ins/palette-to-gradient/palette-to-gradient.py'...
wrapping `/nix/store/5ypz5l6m1qbh89kpsqjr6h5c3cv43fj3-gimp-2.10.6/lib/gimp/2.0/plug-ins/colorxhtml/colorxhtml.py'...
wrapping `/nix/store/5ypz5l6m1qbh89kpsqjr6h5c3cv43fj3-gimp-2.10.6/lib/gimp/2.0/plug-ins/py-slice/py-slice.py'...
wrapping `/nix/store/5ypz5l6m1qbh89kpsqjr6h5c3cv43fj3-gimp-2.10.6/lib/gimp/2.0/plug-ins/python-console/python-console.py'...
wrapping `/nix/store/5ypz5l6m1qbh89kpsqjr6h5c3cv43fj3-gimp-2.10.6/lib/gimp/2.0/plug-ins/file-openraster/file-openraster.py'...
wrapping `/nix/store/5ypz5l6m1qbh89kpsqjr6h5c3cv43fj3-gimp-2.10.6/lib/gimp/2.0/plug-ins/python-eval/python-eval.py'...
wrapping `/nix/store/5ypz5l6m1qbh89kpsqjr6h5c3cv43fj3-gimp-2.10.6/lib/gimp/2.0/plug-ins/foggify/foggify.py'...
wrapping `/nix/store/5ypz5l6m1qbh89kpsqjr6h5c3cv43fj3-gimp-2.10.6/lib/gimp/2.0/plug-ins/gradients-save-as-css/gradients-save-as-css.py'...
/nix/store/5ypz5l6m1qbh89kpsqjr6h5c3cv43fj3-gimp-2.10.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gimp

Partial log (click to expand)

wrapping `/nix/store/n3j6nxmqq0ikpr5avv85bgn3aqganb6x-gimp-2.10.6/lib/gimp/2.0/plug-ins/palette-to-gradient/palette-to-gradient.py'...
wrapping `/nix/store/n3j6nxmqq0ikpr5avv85bgn3aqganb6x-gimp-2.10.6/lib/gimp/2.0/plug-ins/palette-sort/palette-sort.py'...
wrapping `/nix/store/n3j6nxmqq0ikpr5avv85bgn3aqganb6x-gimp-2.10.6/lib/gimp/2.0/plug-ins/palette-offset/palette-offset.py'...
wrapping `/nix/store/n3j6nxmqq0ikpr5avv85bgn3aqganb6x-gimp-2.10.6/lib/gimp/2.0/plug-ins/histogram-export/histogram-export.py'...
wrapping `/nix/store/n3j6nxmqq0ikpr5avv85bgn3aqganb6x-gimp-2.10.6/lib/gimp/2.0/plug-ins/gradients-save-as-css/gradients-save-as-css.py'...
wrapping `/nix/store/n3j6nxmqq0ikpr5avv85bgn3aqganb6x-gimp-2.10.6/lib/gimp/2.0/plug-ins/foggify/foggify.py'...
wrapping `/nix/store/n3j6nxmqq0ikpr5avv85bgn3aqganb6x-gimp-2.10.6/lib/gimp/2.0/plug-ins/file-openraster/file-openraster.py'...
wrapping `/nix/store/n3j6nxmqq0ikpr5avv85bgn3aqganb6x-gimp-2.10.6/lib/gimp/2.0/plug-ins/colorxhtml/colorxhtml.py'...
wrapping `/nix/store/n3j6nxmqq0ikpr5avv85bgn3aqganb6x-gimp-2.10.6/lib/gimp/2.0/plug-ins/python-console/python-console.py'...
/nix/store/n3j6nxmqq0ikpr5avv85bgn3aqganb6x-gimp-2.10.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gimp

Partial log (click to expand)

wrapping `/nix/store/jlphd3jbz1bzb1s3im1f3q728fbm1ik1-gimp-2.10.6/lib/gimp/2.0/plug-ins/palette-sort/palette-sort.py'...
wrapping `/nix/store/jlphd3jbz1bzb1s3im1f3q728fbm1ik1-gimp-2.10.6/lib/gimp/2.0/plug-ins/palette-to-gradient/palette-to-gradient.py'...
wrapping `/nix/store/jlphd3jbz1bzb1s3im1f3q728fbm1ik1-gimp-2.10.6/lib/gimp/2.0/plug-ins/colorxhtml/colorxhtml.py'...
wrapping `/nix/store/jlphd3jbz1bzb1s3im1f3q728fbm1ik1-gimp-2.10.6/lib/gimp/2.0/plug-ins/py-slice/py-slice.py'...
wrapping `/nix/store/jlphd3jbz1bzb1s3im1f3q728fbm1ik1-gimp-2.10.6/lib/gimp/2.0/plug-ins/python-console/python-console.py'...
wrapping `/nix/store/jlphd3jbz1bzb1s3im1f3q728fbm1ik1-gimp-2.10.6/lib/gimp/2.0/plug-ins/file-openraster/file-openraster.py'...
wrapping `/nix/store/jlphd3jbz1bzb1s3im1f3q728fbm1ik1-gimp-2.10.6/lib/gimp/2.0/plug-ins/python-eval/python-eval.py'...
wrapping `/nix/store/jlphd3jbz1bzb1s3im1f3q728fbm1ik1-gimp-2.10.6/lib/gimp/2.0/plug-ins/foggify/foggify.py'...
wrapping `/nix/store/jlphd3jbz1bzb1s3im1f3q728fbm1ik1-gimp-2.10.6/lib/gimp/2.0/plug-ins/gradients-save-as-css/gradients-save-as-css.py'...
/nix/store/jlphd3jbz1bzb1s3im1f3q728fbm1ik1-gimp-2.10.6

@globin globin merged commit d3cfda1 into NixOS:master Nov 7, 2018
@pbogdan pbogdan deleted the gimp-no-cc branch December 3, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pbogdan @GrahamcOfBorg @jtojnar @globin