Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

klaus: add markdown rendering support #49811

Closed
wants to merge 1 commit into from
Closed

klaus: add markdown rendering support #49811

wants to merge 1 commit into from

Conversation

royneary
Copy link
Contributor

@royneary royneary commented Nov 6, 2018

Motivation for this change

markdown rendering (e.g. readme files)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@royneary royneary requested a review from FRidh as a code owner November 6, 2018 00:14
@FRidh
Copy link
Member

FRidh commented Nov 6, 2018

It's an optional dependency, not a required one. If you want to have markdown support, you can add it in your env.

@FRidh FRidh closed this Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@royneary @FRidh @GrahamcOfBorg