Skip to content

pythonPackages.autologging: init at 1.2.1 #49828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2018
Merged

pythonPackages.autologging: init at 1.2.1 #49828

merged 1 commit into from
Nov 7, 2018
+21 −0

Conversation

Twey
Copy link
Contributor

@Twey Twey commented Nov 6, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Twey Twey requested a review from FRidh as a code owner November 6, 2018 14:15
@Ma27
Copy link
Member

Ma27 commented Nov 7, 2018

The change itself is looking good, but may I ask why you didn't add yourself as maintainer? It's AFAIK not a hard rule, but I think it's preferable to attempt to have as many maintained packages as possible in the master.

@Twey
Copy link
Contributor Author

Twey commented Nov 7, 2018

Just because I forgot :) Fixed.

@Ma27
Copy link
Member

Ma27 commented Nov 7, 2018

built locally, but I'd like to confirm that it works on different platforms as well, then it should be safe to merge :)

@GrahamcOfBorg build pythonPackages.autologging python3Packages.autologging

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.autologging, python3Packages.autologging

Partial log (click to expand)

test_nested_function_trace_records_when_log_disabled (test.functest_logged_and_traced.LoggedAndTracedFunctionFunctionalTest) ... ok
test_classmethod_generator (test.functest_traced_generator.TracedGeneratorFunctionalTest) ... ok
test_method_generator (test.functest_traced_generator.TracedGeneratorFunctionalTest) ... ok
test_staticmethod_generator (test.functest_traced_generator.TracedGeneratorFunctionalTest) ... ok
test_traced_function_generator (test.functest_traced_generator.TracedGeneratorFunctionalTest) ... ok

----------------------------------------------------------------------
Ran 142 tests in 0.038s

OK

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pythonPackages.autologging, python3Packages.autologging

Partial log (click to expand)

test_nested_function_trace_records_when_log_disabled (test.functest_logged_and_traced.LoggedAndTracedFunctionFunctionalTest) ... ok
test_classmethod_generator (test.functest_traced_generator.TracedGeneratorFunctionalTest) ... ok
test_method_generator (test.functest_traced_generator.TracedGeneratorFunctionalTest) ... ok
test_staticmethod_generator (test.functest_traced_generator.TracedGeneratorFunctionalTest) ... ok
test_traced_function_generator (test.functest_traced_generator.TracedGeneratorFunctionalTest) ... ok

----------------------------------------------------------------------
Ran 142 tests in 0.028s

OK

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.autologging, python3Packages.autologging

Partial log (click to expand)

test_nested_function_trace_records_when_log_disabled (test.functest_logged_and_traced.LoggedAndTracedFunctionFunctionalTest) ... ok
test_classmethod_generator (test.functest_traced_generator.TracedGeneratorFunctionalTest) ... ok
test_method_generator (test.functest_traced_generator.TracedGeneratorFunctionalTest) ... ok
test_staticmethod_generator (test.functest_traced_generator.TracedGeneratorFunctionalTest) ... ok
test_traced_function_generator (test.functest_traced_generator.TracedGeneratorFunctionalTest) ... ok

----------------------------------------------------------------------
Ran 142 tests in 0.048s

OK

@Ma27 Ma27 merged commit 8c68a7d into NixOS:master Nov 7, 2018
@Ma27
Copy link
Member

Ma27 commented Nov 7, 2018

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Twey @Ma27 @GrahamcOfBorg