Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steamPackages.steam-runtime-wrapped: don't include all of gcc #49808

Merged
merged 1 commit into from Nov 24, 2018
Merged

steamPackages.steam-runtime-wrapped: don't include all of gcc #49808

merged 1 commit into from Nov 24, 2018

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Nov 5, 2018

Motivation for this change

As I understand it that override is used to provide a newer version of libstdc++ and for that the lib output alone should be sufficient.

/cc @abbradar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@pbogdan
Copy link
Member Author

pbogdan commented Nov 22, 2018

Ping?

@lheckemann lheckemann merged commit 5c9b19a into NixOS:master Nov 24, 2018
@pbogdan pbogdan deleted the steam-cc branch December 3, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants