Skip to content

gucci: init at 0.1.0 #49813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2018
Merged

gucci: init at 0.1.0 #49813

merged 2 commits into from
Nov 7, 2018
+67 −0

Conversation

braydenjw
Copy link
Contributor

@braydenjw braydenjw commented Nov 6, 2018 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 6, 2018
@srhb srhb self-assigned this Nov 6, 2018
@srhb
Copy link
Contributor

srhb commented Nov 6, 2018

Hi @braydenjw and thank you for contributing to nixpkgs. 😃 Please take a look at pkgs/top-level/all-packages.nix and find a relevant section in which to introduce the callPackage call, such that the package is actually exposed as a top-level attribute (I think ### TOOLS is appropriate).

srhb
srhb requested changes Nov 6, 2018
View reviewed changes
@braydenjw
Copy link
Contributor Author

Hi @braydenjw and thank you for contributing to nixpkgs. smiley Please take a look at pkgs/top-level/all-packages.nix and find a relevant section in which to introduce the callPackage call, such that the package is actually exposed as a top-level attribute (I think ### TOOLS is appropriate).

Thank you for the warm welcome and for being so helpful!

I added it to the ### TOOLS section as you suggested.

@srhb
Copy link
Contributor

srhb commented Nov 7, 2018

I added it to the ### TOOLS section as you suggested.

@braydenjw Hmm, I don't see it in the commits here. Did you push it to the master branch of your fork?

@srhb
Copy link
Contributor

srhb commented Nov 7, 2018

Oh, overlap. :)

@srhb
Copy link
Contributor

srhb commented Nov 7, 2018

@GrahamcOfBorg build gucci

@braydenjw
Copy link
Contributor Author

Oh, overlap. :)

You're scary fast.

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 7, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gucci

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/ggv5r0dzpgf9vqq8mcbcvvb9rbsp5v9k-gucci-0.1.0-bin
shrinking /nix/store/ggv5r0dzpgf9vqq8mcbcvvb9rbsp5v9k-gucci-0.1.0-bin/bin/gucci
cannot find section .dynamic
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ggv5r0dzpgf9vqq8mcbcvvb9rbsp5v9k-gucci-0.1.0-bin/bin
patching script interpreter paths in /nix/store/ggv5r0dzpgf9vqq8mcbcvvb9rbsp5v9k-gucci-0.1.0-bin
checking for references to /build in /nix/store/ggv5r0dzpgf9vqq8mcbcvvb9rbsp5v9k-gucci-0.1.0-bin...
cannot find section .dynamic
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
/nix/store/ggv5r0dzpgf9vqq8mcbcvvb9rbsp5v9k-gucci-0.1.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gucci

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/rxywxxazqa31rci7yksppy2qlcnbyll7-gucci-0.1.0-bin
shrinking /nix/store/rxywxxazqa31rci7yksppy2qlcnbyll7-gucci-0.1.0-bin/bin/gucci
cannot find section .dynamic
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rxywxxazqa31rci7yksppy2qlcnbyll7-gucci-0.1.0-bin/bin
patching script interpreter paths in /nix/store/rxywxxazqa31rci7yksppy2qlcnbyll7-gucci-0.1.0-bin
checking for references to /build in /nix/store/rxywxxazqa31rci7yksppy2qlcnbyll7-gucci-0.1.0-bin...
cannot find section .dynamic
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/rxywxxazqa31rci7yksppy2qlcnbyll7-gucci-0.1.0-bin

@srhb srhb merged commit e11c3a0 into NixOS:master Nov 7, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gucci

Partial log (click to expand)

find: '/nix/store/79r6hmx49m1nimvpw6hb1pxdgkpd64dq-gucci-0.1.0': No such file or directory
find: '/nix/store/79r6hmx49m1nimvpw6hb1pxdgkpd64dq-gucci-0.1.0': No such file or directory
find: '/nix/store/79r6hmx49m1nimvpw6hb1pxdgkpd64dq-gucci-0.1.0': No such file or directory
find: '/nix/store/79r6hmx49m1nimvpw6hb1pxdgkpd64dq-gucci-0.1.0': No such file or directory
find: '/nix/store/79r6hmx49m1nimvpw6hb1pxdgkpd64dq-gucci-0.1.0': No such file or directory
find: '/nix/store/79r6hmx49m1nimvpw6hb1pxdgkpd64dq-gucci-0.1.0': No such file or directory
find: '/nix/store/79r6hmx49m1nimvpw6hb1pxdgkpd64dq-gucci-0.1.0': No such file or directory
find: '/nix/store/79r6hmx49m1nimvpw6hb1pxdgkpd64dq-gucci-0.1.0': No such file or directory
find: '/nix/store/79r6hmx49m1nimvpw6hb1pxdgkpd64dq-gucci-0.1.0': No such file or directory
/nix/store/9y9kaybym605r2b6frar7v4069jbrg49-gucci-0.1.0-bin

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb

Assignees

@srhb srhb

Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@braydenjw @srhb @GrahamcOfBorg @Janik-Haag