Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plymouth: 0.9.3 -> 0.9.4 #49816

Merged
merged 1 commit into from Nov 14, 2018
Merged

plymouth: 0.9.3 -> 0.9.4 #49816

merged 1 commit into from Nov 14, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Nov 6, 2018

Motivation for this change

https://cgit.freedesktop.org/plymouth/tag/?h=0.9.4

Note: I haven't tested this personally (other than build testing).
Since proper integration is what makes or breaks this,
someone should at least check a boot or two?

But thought I'd get it ready for our tester ;).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: plymouth

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: plymouth

Partial log (click to expand)

strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/59x37f5a1n0ckgh2kjla336z6hh89nk7-plymouth-0.9.4
stripping (with command strip and flags -S) in /nix/store/59x37f5a1n0ckgh2kjla336z6hh89nk7-plymouth-0.9.4/lib  /nix/store/59x37f5a1n0ckgh2kjla336z6hh89nk7-plymouth-0.9.4/bin  /nix/store/59x37f5a1n0ckgh2kjla336z6hh89nk7-plymouth-0.9.4/sbin
patching script interpreter paths in /nix/store/59x37f5a1n0ckgh2kjla336z6hh89nk7-plymouth-0.9.4
/nix/store/59x37f5a1n0ckgh2kjla336z6hh89nk7-plymouth-0.9.4/lib/plymouth/plymouth-update-initrd: interpreter directive changed from "/bin/bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/59x37f5a1n0ckgh2kjla336z6hh89nk7-plymouth-0.9.4/lib/plymouth/plymouth-generate-initrd: interpreter directive changed from "/bin/bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/59x37f5a1n0ckgh2kjla336z6hh89nk7-plymouth-0.9.4/lib/plymouth/plymouth-populate-initrd: interpreter directive changed from "/bin/bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
/nix/store/59x37f5a1n0ckgh2kjla336z6hh89nk7-plymouth-0.9.4/sbin/plymouth-set-default-theme: interpreter directive changed from "/bin/bash" to "/nix/store/r47p5pzx52m3n34vdgqpk5rvqgm0m24m-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/59x37f5a1n0ckgh2kjla336z6hh89nk7-plymouth-0.9.4...
moving /nix/store/59x37f5a1n0ckgh2kjla336z6hh89nk7-plymouth-0.9.4/sbin/* to /nix/store/59x37f5a1n0ckgh2kjla336z6hh89nk7-plymouth-0.9.4/bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: plymouth

Partial log (click to expand)

strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9xn7flqdjw5g2jpjhl0qqlvnr0g3mj0h-plymouth-0.9.4/lib  /nix/store/9xn7flqdjw5g2jpjhl0qqlvnr0g3mj0h-plymouth-0.9.4/bin  /nix/store/9xn7flqdjw5g2jpjhl0qqlvnr0g3mj0h-plymouth-0.9.4/sbin
patching script interpreter paths in /nix/store/9xn7flqdjw5g2jpjhl0qqlvnr0g3mj0h-plymouth-0.9.4
/nix/store/9xn7flqdjw5g2jpjhl0qqlvnr0g3mj0h-plymouth-0.9.4/sbin/plymouth-set-default-theme: interpreter directive changed from "/bin/bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
/nix/store/9xn7flqdjw5g2jpjhl0qqlvnr0g3mj0h-plymouth-0.9.4/lib/plymouth/plymouth-populate-initrd: interpreter directive changed from "/bin/bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
/nix/store/9xn7flqdjw5g2jpjhl0qqlvnr0g3mj0h-plymouth-0.9.4/lib/plymouth/plymouth-generate-initrd: interpreter directive changed from "/bin/bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
/nix/store/9xn7flqdjw5g2jpjhl0qqlvnr0g3mj0h-plymouth-0.9.4/lib/plymouth/plymouth-update-initrd: interpreter directive changed from "/bin/bash" to "/nix/store/dsyc1z7ck08ga7l0b1jcxx35wj69qcii-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/9xn7flqdjw5g2jpjhl0qqlvnr0g3mj0h-plymouth-0.9.4...
moving /nix/store/9xn7flqdjw5g2jpjhl0qqlvnr0g3mj0h-plymouth-0.9.4/sbin/* to /nix/store/9xn7flqdjw5g2jpjhl0qqlvnr0g3mj0h-plymouth-0.9.4/bin
/nix/store/9xn7flqdjw5g2jpjhl0qqlvnr0g3mj0h-plymouth-0.9.4

worldofpeace
worldofpeace approved these changes Nov 11, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've deployed this to one of my machines and it boots up fine. 👍

@lheckemann
Copy link
Member

Wanted to test this in a VM, but apparently build-vm-with-bootloader is broken. @worldofpeace did it show the fancy boot graphics? If so I'd say we should merge.

@worldofpeace
Copy link
Contributor

did it show the fancy boot graphics? If so I'd say we should merge.

@lheckemann I've been running it on a machine and it's quiet pretty 😄

I think it's good to merge.

@infinisil infinisil merged commit e1f0cd5 into NixOS:master Nov 14, 2018
@worldofpeace
Copy link
Contributor

✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @GrahamcOfBorg @lheckemann @worldofpeace @infinisil