Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add chapter on Profiles #49821

Merged
merged 17 commits into from Nov 14, 2018
Merged

Conversation

DIzFer
Copy link
Contributor

@DIzFer DIzFer commented Nov 6, 2018

Motivation for this change

Profiles lack discovery and documentation. Hopefully this is the beginning of a fix. Clone-config is empty because I haven't had the time to understand what it does, so someone should provide at least a short summary.

In fact, I'd like to have insight on why most options are set in each profile, I just resorted to state what is set, without a reason why.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Mic92 and others added 5 commits November 6, 2018 22:48
Co-Authored-By: DIzFer <david@izquierdofernandez.com>
Co-Authored-By: DIzFer <david@izquierdofernandez.com>
Co-Authored-By: DIzFer <david@izquierdofernandez.com>
Co-Authored-By: DIzFer <david@izquierdofernandez.com>
Co-Authored-By: DIzFer <david@izquierdofernandez.com>
@lheckemann
Copy link
Member

lheckemann commented Nov 14, 2018

Some of these commits should probably be squashed, but other than that LGTM.

@Mic92 Mic92 merged commit 6f607b8 into NixOS:master Nov 14, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 14, 2018

For documentation I am not so picky when it comes to a clean git history. For line-based diffs are not so useful anyway.

@DIzFer DIzFer deleted the profiles-documentation branch November 15, 2018 12:11
@worldofpeace worldofpeace mentioned this pull request Oct 22, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants