Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "zfs cannot be distributed. Disabling it in the isos." #51090

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Revert "zfs cannot be distributed. Disabling it in the isos." #51090

merged 1 commit into from
Nov 29, 2018
+1 −1

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Nov 26, 2018

ZFS's popularity is growing, and not including it by default is a
bit frustrating. On top of that, the base iso includes ZFS
anyway due to other packages depending upon it.

I think we're in the clear to do this on the basis that Oracle
probably doesn't care, it is probably fine (the SFLC agrees) and
we're a small fish. If a copyright holder asks us to, we can
definitely revert it again.

This reverts commit 33d07c7.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@grahamc
Revert "zfs cannot be distributed. Disabling it in the isos."
6db866c 
ZFS's popularity is growing, and not including it by default is a
bit frustrating. On top of that, the base iso includes ZFS
_anyway_ due to other packages depending upon it.

I think we're in the clear to do this on the basis that Oracle
probably doesn't care, it is probably fine (the SFLC agrees) and
we're a small fish. If a copyright holder asks us to, we can
definitely revert it again.

This reverts commit 33d07c7.
@grahamc grahamc requested a review from infinisil as a code owner November 26, 2018 22:54
grahamc referenced this pull request Nov 26, 2018
@viric
zfs cannot be distributed. Disabling it in the isos.
33d07c7 
It seems that it is a GPL violation to distribute zfs in the
installation ISOs.

https://sfconservancy.org/blog/2016/feb/25/zfs-and-linux/

If anyone knows the issue better and has a reason to reenable it
legally, feel free to reenable it. I don't know much about it.
@grahamc
Copy link
Member Author

grahamc commented Nov 26, 2018

@armijnhemel says:

"if we ship the ZFS source code, then for all practical purposes the GPL has been fullfilled in my opinion. This also seems to be the opinion of Ubuntu and SFLC."

and we do distribute the source code via binary cache, and the build instructions by virtue of having nixpkgs in the image.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 26, 2018
vcunat
vcunat approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risks vs. benefits ratio seems very favorable to me.

@vcunat
Copy link
Member

vcunat commented Nov 28, 2018

I believe this is safe for 18.09, too.

@grahamc grahamc merged commit e488f62 into NixOS:master Nov 29, 2018
@grahamc grahamc deleted the revert-disable-zfs branch November 29, 2018 13:37
@grahamc
Copy link
Member Author

grahamc commented Nov 29, 2018

Backported in a0c7949

@samueldr samueldr mentioned this pull request Feb 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grahamc @vcunat @GrahamcOfBorg