Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kustomize: 1.0.9 -> 1.0.10 #51069

Merged
merged 1 commit into from Nov 27, 2018
Merged

kustomize: 1.0.9 -> 1.0.10 #51069

merged 1 commit into from Nov 27, 2018

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Nov 26, 2018 •
edited

Signed-off-by: Vincent Demeester vincent@sbr.pm

Motivation for this change

Bump to latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nlewo
Copy link
Member

nlewo commented Nov 26, 2018

@GrahamcOfBorg build kustomize

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kustomize

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3hn1xq0vzw1zsrjr4x6xxxw5r6cbzaag-kustomize-1.0.10-bin
shrinking /nix/store/3hn1xq0vzw1zsrjr4x6xxxw5r6cbzaag-kustomize-1.0.10-bin/bin/kustomize
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3hn1xq0vzw1zsrjr4x6xxxw5r6cbzaag-kustomize-1.0.10-bin/bin
patching script interpreter paths in /nix/store/3hn1xq0vzw1zsrjr4x6xxxw5r6cbzaag-kustomize-1.0.10-bin
checking for references to /build in /nix/store/3hn1xq0vzw1zsrjr4x6xxxw5r6cbzaag-kustomize-1.0.10-bin...
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
/nix/store/3hn1xq0vzw1zsrjr4x6xxxw5r6cbzaag-kustomize-1.0.10-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kustomize

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4i0ssfy522sgxf437b2nk35f7sy3q068-kustomize-1.0.10-bin
shrinking /nix/store/4i0ssfy522sgxf437b2nk35f7sy3q068-kustomize-1.0.10-bin/bin/kustomize
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4i0ssfy522sgxf437b2nk35f7sy3q068-kustomize-1.0.10-bin/bin
patching script interpreter paths in /nix/store/4i0ssfy522sgxf437b2nk35f7sy3q068-kustomize-1.0.10-bin
checking for references to /build in /nix/store/4i0ssfy522sgxf437b2nk35f7sy3q068-kustomize-1.0.10-bin...
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
/nix/store/4i0ssfy522sgxf437b2nk35f7sy3q068-kustomize-1.0.10-bin

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: kustomize

Partial log (click to expand)

cannot build derivation '/nix/store/dwhz4sd735pk7l7pa7nzs4brrlix44qm-top-osx-10.11.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/ajw9qf20c1qahk1l7bznq32g35xlcdg3-system_cmds-osx-10.11.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3gb7y31c9mcsjjrmga0fbhz65q11scyi-top-1003.1-2008.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/brl8cnz9bqihmpk5hlwkmii0qy89jqjz-sysctl-1003.1-2008.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/xd51xjyxmrpdmdzrma76jqym3dcva0v5-procps-1003.1-2008.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/frdndal97j907fgwz1d0bf0sv378frx2-go-1.11.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kd8s08kbz0y9qy1h9pbkvddrvh24rlhn-parallel-20181022.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/qa3ylsdv4b2g8kzppp3ps0n3lj6zj79q-govers-20150109-3b5f175.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/n5k85bpnanyjm3l04z0xn1vyi633jld6-kustomize-1.0.10.drv': 3 dependencies couldn't be built
error: build of '/nix/store/n5k85bpnanyjm3l04z0xn1vyi633jld6-kustomize-1.0.10.drv' failed

c0bw3b
c0bw3b reviewed Nov 27, 2018
View reviewed changes
pkgs/development/tools/kustomize/default.nix
rev = "ec86b30d2b01a8fa62e645f024f26bfea5dcd30d";
version = "1.0.10";
# rev is the 1.0.10 commit, mainly for kustomize version command output
rev = "383b3e798b7042f8b7431f93e440fb85631890a3";
Copy link
Contributor

@c0bw3b c0bw3b Nov 27, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand why we don't use the v1.0.10 release tag

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c0bw3b it's to populate the gitCommit field of the version output (as the published releases)

@vdemeester
kustomize: 1.0.9 -> 1.0.10
2d5908f 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@nlewo nlewo merged commit 71b49f2 into NixOS:master Nov 27, 2018
@vdemeester vdemeester deleted the update-kustomize branch November 27, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vdemeester @nlewo @GrahamcOfBorg @c0bw3b